I'm using the module with setting output resolution to 0 (so the ratio and min size checkboxes are unchecked).
I get the following notices after saving the field edit form:
Notice: Uninitialized string offset: 0 in _imagefield_crop_widget_enforce_ratio_validate() (line 137 of path_to_drupal\sites\all\modules\imagefield_crop\imagefield_crop.module).
Notice: Uninitialized string offset: 0 in _imagefield_crop_widget_enforce_minimum_validate() (line 144 of path_to_drupal\sites\all\modules\imagefield_crop\imagefield_crop.module).
Notice: Uninitialized string offset: 0 in _imagefield_crop_widget_enforce_minimum_validate() (line 145 of path_to_drupal\sites\all\modules\imagefield_crop\imagefield_crop.module).
and these on the node edit screen:
Notice: Undefined offset: 1 in imagefield_crop_widget_process() (line 211 of path_to_drupal\sites\all\modules\imagefield_crop\imagefield_crop.module).
Notice: Undefined variable: width in imagefield_crop_widget_preview_process() (line 308 of path_to_drupal\sites\all\modules\imagefield_crop\imagefield_crop.module).
Notice: Undefined variable: height in imagefield_crop_widget_preview_process() (line 309 of path_to_drupal\sites\all\modules\imagefield_crop\imagefield_crop.module).
Notice: Undefined variable: width in imagefield_crop_widget_preview_process() (line 321 of path_to_drupal\sites\all\modules\imagefield_crop\imagefield_crop.module).
Notice: Undefined variable: height in imagefield_crop_widget_preview_process() (line 322 of path_to_drupal\sites\all\modules\imagefield_crop\imagefield_crop.module).
Comment | File | Size | Author |
---|---|---|---|
#11 | imagefield_crop-php_notices_no_resolution-2090141-11.patch | 2.29 KB | jenlampton |
#9 | php_notices_with_no_resolution_2090141_9.patch | 2.02 KB | vladimir.krupin |
#6 | php_notices_with_no_resolution_2090141_6.patch | 2.47 KB | likewhoa |
Comments
Comment #1
progpapa CreditAttribution: progpapa commentedThe attached patch seems to solve the issues.
Comment #2
joetsuihk CreditAttribution: joetsuihk commented@progpapa thanks for the patch. But I cannot save the new crop image for some reason. You can?
Comment #3
progpapa CreditAttribution: progpapa commentedLooks like it doesn't like the way I'm hiding the preview + there were a few other places that needed some changes.
Please try the new patch, it works for me. It might need some more work, but hopefully it's getting close. :)
Comment #4
likewhoa CreditAttribution: likewhoa commentedHad to re-roll patch with some changes. Now all notices are gone.
Comment #5
likewhoa CreditAttribution: likewhoa commentedSeems I missed something which php-5.6 didn't care about. This is a re-rolled of my previous patch.
Comment #6
likewhoa CreditAttribution: likewhoa commentedre-roll
Comment #7
Alex Bukach CreditAttribution: Alex Bukach commented#6 works for me. Thanks!
Comment #8
SchwebDesign CreditAttribution: SchwebDesign commentedI had to implement a combination of patch #1 and #6. but it seems to have fixed the issue.
Comment #9
vladimir.krupin CreditAttribution: vladimir.krupin at DrupalJedi commentedAfter applying #6 croparea size is lost and image is shown in full size.
There is patch
Comment #10
Gnanasampandan Velmurgan CreditAttribution: Gnanasampandan Velmurgan as a volunteer commentedAfter applying the #9 patch. All notice issues get solved. Thanks.
Comment #11
jenlamptonI was having trouble with the patch file formatting, so rerolled. But based on the feedback in #10, marking as RTBC.