I am running drupal 7.22
webform 7.x-4.0-alpha6
Mail system 7.x-2.34

with the latest dev version of mimemail

I am trying to get mimemail to send files uploaded to my webforms as attachments.

This is working just fine when I send files that do not have spaces in them.
But if the filenames have spaces in them, the files do not get attached to the email.

Is this a mimemail issue?

Thanks

alan

CommentFileSizeAuthor
#12 mimemail-2087913-12.patch3.9 KBsgabe
#9 mimemail-2087913-9.patch2.81 KBsgabe
#6 mimemail-2087913-6.patch980 bytessgabe

Comments

trentl’s picture

trentl commented

Using version beta1 of mime mail I am seeing the same thing. Files with spaces in their names do not get attached, and files without do.

trentl’s picture

trentl commented

I can confirm that this is a bug in Mime Mail. I rolled back go Alpha2 and Mime Mail successfully sends attachments with spaces in the file names. Beta1 does not.

Steps to reproduce:

1) Create form with file field component
2) Configure form and check "send files as attachments"
3) Test form by uploading file name with spaces

Result - if file name has spaces, it will not be sent as an attachment. Using alpha2 version does not exhibit this behavior.

Since this is a support request against the dev version, I'm going to open a bug in the beta2 queue.

sgabe’s picture

sgabe commented

@geeklygroup: Please do not open a new issue, but change this one to a bug report.

belio’s picture

belio commented
Version: 7.x-1.x-dev » 7.x-1.0-beta1
Category: Support request » Bug report
Issue summary: View changes

I'm having the same problem. Rolling back to Alfa2 for now.

splitsplitsplit’s picture

splitsplitsplit commented

Also having the same problem in the beta. Rolled back to the alpha.

Also in the alpha2 version I can't seem to send text files. Word files and pdf's work fine.

sgabe’s picture

sgabe commented
Title: File Attachments with spaces » File attachments with spaces
Status: Active » Needs review
StatusFileSize
new mimemail-2087913-6.patch980 bytes

Please test the attached patch and report back.

Status: Needs review » Needs work

The last submitted patch, 6: mimemail-2087913-6.patch, failed testing.

jesss’s picture

jesss commented

I applied the patch manually and it's working great for me. Thanks!

sgabe’s picture

sgabe commented
Status: Needs work » Needs review
StatusFileSize
new mimemail-2087913-9.patch2.81 KB

Updated patch attached with refactored _mimemail_url() function and a tiny test for this specific bug.

Status: Needs review » Needs work

The last submitted patch, 9: mimemail-2087913-9.patch, failed testing.

sgabe’s picture

sgabe commented
Version: 7.x-1.0-beta1 » 7.x-1.x-dev
Status: Needs work » Needs review

Version should be set to the branch to allow tests.

sgabe’s picture

sgabe commented
Title: File attachments with spaces » Allow spaces in attachment filenames
Status: Needs review » Fixed
StatusFileSize
new mimemail-2087913-12.patch3.9 KB

The attached patch with refactored _mimemail_url() function and some tests has been committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.