When I add a right sidebar to a flexible layout panel node, the 'Save' and 'Cancel' buttons are below this right sidebar (and also not useable) rather than below the layout in the 'panel content' ajax form. I can reproduce that with Garland and Gagarin themes at least. With no right sidebar, everything is fine.

CommentFileSizeAuthor
#6 flexible.inc.patch663 bytespvasener

Comments

pvasener’s picture

pvasener commented

I corrected this problem adding a clearing div before the 'save' button. I presume it's safe and can be considered as a fix. Here is the modified code of the includes/display_edit.inc file:

  $form['submit'] = array(
    '#type' => 'submit',
    '#value' => t('Save'),
    '#id' => 'panels-dnd-save',
    '#prefix' => '<div style="clear: both"></div>',
  );
criz’s picture

criz
he/him
Location Vienna/Austria
commented
Status: Active » Reviewed & tested by the community

yes, I ran over the same bug. this fixed it. thx.

pvasener’s picture

pvasener commented
Version: 5.x-2.0-beta1 » 5.x-2.0-beta2

For information, the bug is still present in beta2 and the fix still works.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Drupal core has css declarations for class="clear-block" which saves on adding inline styles. Also, why not a #prefix and #suffix around these rather than the empty div above?

Thanks for posting this up, could you supply the changes as a .patch file according to http://drupal.org/patch

merlinofchaos’s picture

merlinofchaos commented

I think the clear-block designation should just go on the main div for flexible itself. That would likely solve the issue.

pvasener’s picture

pvasener commented
Status: Needs work » Needs review
StatusFileSize
new flexible.inc.patch663 bytes

Yep Merlinofchaos, this is also working this way and certainly much cleaner. Here is a proposed patch.

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Reviewed & tested by the community

+1!

Thank you!

I'll leave this RTBC before I commit for further comments (and because I'm working on Views right now, and don't want to switch), but this'll go in.

catch’s picture

catch
he/him
Primary language English
commented

Haven't tested the patch, but putting it on the flexible div sounds much more sensible, might not only be those buttons which get misplaced otherwise.

john morahan’s picture

john morahan commented

Tested and working for me in Firefox 2.0.0.11.

sdboyer’s picture

sdboyer commented
Status: Reviewed & tested by the community » Fixed

Committed.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.