There's some nitpicks found while working on d8 port

Comments

andypost’s picture

Status: Active » Needs review
StatusFileSize
new3.67 KB

Suggested changes

greggles’s picture

All of it seems reasonable to me except:

 
 class EmailRegistrationTestCase extends DrupalWebTestCase {
@@ -64,6 +64,6 @@ class EmailRegistrationTestCase extends DrupalWebTestCase {
     );
     $this->drupalPost('/user/register', $register, t('Create new account'));
     $this->assertRaw('Registration successful. You are now logged in.', t('User properly created, immediately logged in.'));
-
   }
+
 }

Why add that empty line?

andypost’s picture

@greggles See - Object-oriented code https://drupal.org/node/608152

Leave an empty line between end of method and end of class definition

greggles’s picture

Status: Needs review » Reviewed & tested by the community

Okey doke.

andypost’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, Greg! pushed f47b99d

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.