Updated: Comment #0

Problem/Motivation

After upgrading to ds-7.x-2.5 much of the javascript related features on the Manage Displays tab of my content types stopped working. I was no longer able to drag-reorder fields, the indicator provided by the Environment Indicator module did not display, and Admin Menu module's menu disappeared (sometimes). downgrading to ds-7.x-2.4 fixed things. Upgrading to ds-7.x-2.5 broke them again.

I was using jquery_update-7.x-2.3, which was set to use jquery version 1.7. I then upgraded to jquery_update-7.x-2.3+6-dev, which allows setting a different version of jquery on admin pages. When I configure jquery_update to use jquery 1.5 on admin pages, then it seems to all work again. If I change it to 1.7 it breaks again.

CommentFileSizeAuthor
#4 2078637-4.patch629 bytesswentel

Comments

swentel’s picture

swentel commented

I honestly can't see why this is a DS problem. This is more of a jquery update problem, especially since I don't really touch the js of the manage display pages. I'll do a test though, but this is pretty close to won't fix though.

jstoller’s picture

jstoller
he/him
commented

A lot of people use JQuery Update and many modules require it. If DS is incompatible with the newer JQuery versions, that's fine, but it should probably be noted somewhere and this workaround provided. Unless this is all just me.

swentel’s picture

swentel commented

Just for testing, could you open up includes/ds.field_ui.inc and go to line 1674 and comment out that block (with key 'layout_link_custom'). That is using states and I know there are some problems with states and OR/XOR states in core. I could write a workaround for it, but even that is a still a core/jquery update problem.

swentel’s picture

swentel commented
Status: Active » Needs review
StatusFileSize
new 2078637-4.patch629 bytes

Ok, found the problem, damn states ... :)

This makes it work on 1.5 and 1.7

swentel’s picture

swentel commented
Version: 7.x-2.5 » 8.x-2.x-dev
Status: Needs review » Active

Pushed that tot 7.x-2.x, moving to 8.x-2.x to check this is ok there.

aspilicious’s picture

aspilicious commented
Assigned: Unassigned » aspilicious
Status: Active » Needs work

I copied that part so this is probably broken.
Will fix this when I have time.

It's strange the interface isn't broken on jquery 2.0

voodoodan245730’s picture

voodoodan245730 commented

I have the exact same problem after updating..Will try the patch now

swentel’s picture

swentel commented
Title: Jquery_update conflict » Jquery_update conflict and/or drag and drop not working

updating title since people have a hard time find this one :)

swentel’s picture

swentel commented

This is now in the 7.x-2.6 release, see https://drupal.org/node/2081631

aspilicious’s picture

aspilicious commented
Status: Needs work » Fixed

This gets only triggered when token is enabled. There is no token for 8.x yet :D
Thats why I didn't notice it.

swentel’s picture

swentel commented
Status: Fixed » Active

I'm just going to verify for sure :)

aspilicious’s picture

aspilicious commented
Issue summary: View changes
Status: Active » Fixed

Verified this is fixed

aspilicious’s picture

aspilicious commented
Status: Fixed » Closed (fixed)
hansfn’s picture

hansfn commented
Status: Closed (fixed) » Active

I'm opening this again since the problem is still present with DS 7.x-2.6 if you select version 1.8 (instead of 1.7) in the jQuery Update settings. I accept that you might not fix this, but a warning on the project page would be nice. I spent some time tracking it down - to this issue ...

aspilicious’s picture

aspilicious commented
Status: Active » Closed (fixed)

We can't put everything on pur project page. If you're upgrading jquery in the drupal *backend* you're surely asking for problems. Frontend should be ok.