Views displaying wrong data when using references/revisions/multiple fields

Correcting status

I cannot reproduce your error.
I installed Workflow and Workflow Views. Table 'workflow_node' contains the column 'stamp' as expected.
I created a Content View, added all 'Workflow...' fields. The View works a expected.
Is it because you want to use the 'fancy' field to field join from #1090432 ?

@johnv to reproduce follow this steps.

1) Create content type A
2) Create content type B
3) Make content type B reference content type A
4) Create workflow used for content type A
5) Create view that select content type B, add relationship to content type A, add field current comment for content type A (with relationships)

workflow_node works ok for base content type and does not work for content type with relationships, because that code does not use alias

Reassigning.

For another issue, the following, apparently wrong join was removed in #2147535: Add a "Last transition" views filter :
'extra' => 'workflow_node.stamp = workflow_node_current.stamp AND workflow_node.nid = workflow_node_current.nid',

Your code contains more changes, but I trust the problem is gone with version 7.x-2.x

This code
'left_query' => " SELECT max(hid) FROM {workflow_node_history} where nid = node.nid and sid != old_sid ",
would not work either with views relationships.

OK, open again, then.

I'm testing this with Entity Reference to create the reference from A to B. (both having a Workflow Node.)
I do not get your error, but indeed: only the data from the main entity is shown. The reference entity B also shows the data from entity A.

The 'history comments' are fine.

Your patch contains a lot of code for xss, indicating it only solves the 'comment' part.

There is also an error with the other fields of a transition: 'current status', 'time', etc.
IMO the problem should be addressed using the correct table-joins, solving this for all fields.

only the data from the main entity is shown. The reference entity B also shows the data from entity A.

That is the problem. If you add node title field for A and for B, in views you expected to have different values, not the same for main entity.

I'll check patch again to exclude xss.

IMO the problem should be addressed using the correct table-joins, solving this for all fields.

If you will confirm that you will merge the same fixes for other fields, we will create patch for them also.

Yes, I am happy to correct all fields.
I think the problem is in the tables, not the subfields themselves.
P.S. I just made another commit #2149121: Restructure workflow_views_views_data(). on the same code. Please be sure to use the latest code.

I wrote a work-around for the problem using "Workflow current" with views relationships, as described in #7.

It searches for the last state of every node using a "table formula" with subqueries, instead of using the views_join_subquery handler.

My patch from #2074859-15: Views displaying wrong data when using references/revisions/multiple fields have a bug when using more than a workflow field in a content type.

When grouping the rows from workflow_node_history to obtain the latest state of every node, my original query removes all workflow fields except the last one which has a state change.

Now I group by nid and field_name, so the query obtains the latest state from every workflow field of every node.

The patch in #16 fixes the "SQLSTATE[42S22]: Column not found: 1054 Unknown column 'node.nid' in 'where clause'" error that was present in my views after updating to 7.x-2.x.

Patch #6 seems like a step in the good direction. However, I get some wrong results (added in summary).
Also, the code base has changed ITMT.
Can someone take a look at #16 using latest dev-version?

I redid #16 against the stable version - 7.x-2.5. The error I was receiving is gone.

Thanks, @VenDG. We still need some db_query guru to solve the problems in the Issue Summary.

Hello,
I was experimented the same problem when trying to get the workflow's new state of revisions.
For this reason, i have improved the patch #21 to support node_revision entities.
You can try this in this patch(D7 version). It works well for me
Have fun !

See alos:
#2645368: SQL error: Unknown column 'workflow_node_history.entity_type' on a relation
#2645374: SQL error: Views field broken with relation: Workflow current: State name

Thanks all! #23 was committed.
I leave this issue open, until I checked/tested all open problems/sub-issues in the Issue Summary.