A new sub-theme for the Bootstrap framework, originally inspired by the removed Fervens theme.

Front

Node View

Sandbox link: https://drupal.org/sandbox/tr33m4n/2068251

Git: git clone --branch 7.x-1.x tr33m4n@git.drupal.org:sandbox/tr33m4n/2068251.git

CommentFileSizeAuthor
#11 01 Bootstrap Blue.png92.32 KBstockunlocks
#11 02 Bartik 7.22.png73.92 KBstockunlocks
#11 03 Garland 7.22.png64.85 KBstockunlocks
#11 04 Skeleton 7.x-1.2.png61.61 KBstockunlocks
#11 05 Stark 7.22.png68.61 KBstockunlocks
#1 Screenshot from 2013-08-18 13:13:35.png107.21 KBtr33m4n
#1 Screenshot from 2013-08-18 13:15:03.png111.41 KBtr33m4n

Comments

tr33m4n’s picture

tr33m4n commented
StatusFileSize
new Screenshot from 2013-08-18 13:15:03.png111.41 KB
new Screenshot from 2013-08-18 13:13:35.png107.21 KB

Screenshots

ayesh’s picture

ayesh commented

Hi,
There are some issues reported by Ventral.org review system. Please fix them:
http://pareview.sh/pareview/httpgitdrupalorgsandboxtr33m4n2068251git

Looks like the reason to remove Fervens theme is because licensing problems. Are you sure that all PHP code and css/js can be licensed under GPL ?

Also, I think extending your theme-settings to enable the user choose the date format and whether the text resize options should be removed would make the theme better. (It could be confusing because the theme did it without allowing user to disable those features).

ayesh’s picture

ayesh commented
Status: Needs review » Needs work

I'm changing the status to "needs work" because of the master branch and other ventral.org stuff.
Good luck!

tr33m4n’s picture

tr33m4n commented

@Ayesh, good points, will get on that now. As for GPL, yes all code is fine, I took inspiration from the look of Fervens rather than the code base :P

tr33m4n’s picture

tr33m4n commented

Hello again,

I have added the suggested features, text resize is now on or off and the 'submitted by' override can be switched on or off as well as a custom date value added. I have worked through the issues at http://pareview.sh/pareview/httpgitdrupalorgsandboxtr33m4n2068251git however a couple of css formatting issues still exist. I'm not entirely sure about the correct way to format them so they will pass pareview.sh as they are filters in the format of

filter: progid:DXImageTransform.Microsoft.gradient(startColorstr='#ff15a589', endColorstr='#ff15a589', GradientType=0);

Does anyone know the correct way to format them?

tr33m4n’s picture

tr33m4n commented

Updated the Git repo to use 7.x-1.x branch
git clone --branch 7.x-1.x tr33m4n@git.drupal.org:sandbox/tr33m4n/2068251.git

tr33m4n’s picture

tr33m4n commented
Issue summary: View changes

Fixed broken images

tr33m4n’s picture

tr33m4n commented
Status: Needs work » Needs review
PA robot’s picture

PA robot commented

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

snig’s picture

snig commented
Status: Needs review » Needs work
project page
Please take a moment to make your project page follow tips for a great project page.
Master Branch
It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Also:

- in comment:

Implements hook_textarea()

I think you mean theme_textarea
- clean up JavaScript coding standards

tr33m4n’s picture

tr33m4n commented
Status: Needs work » Needs review

Hello there,

  1. Updated the project page to include more information. Will add credits if and when more contributors get involved.
  2. Please refer to comment #6 in which I mention the branch change. I have left the 'master' branch up purely to preserve the amount of commits made, as projects with regular commits have a higher chance of being granted full status
  3. Corrected the incorrect comment in template.php
  4. Cleaned up javascript file to the best of my awareness

Cheers

stockunlocks’s picture

stockunlocks commented
StatusFileSize
new 05 Stark 7.22.png68.61 KB
new 04 Skeleton 7.x-1.2.png61.61 KB
new 03 Garland 7.22.png64.85 KB
new 02 Bartik 7.22.png73.92 KB
new 01 Bootstrap Blue.png92.32 KB

Hi,

Drupal 7.22: Installation went well:

  • Installed Bootstrap theme 7.x-2.1
  • Installed jQuery Update 7.x-2.3 (and configured)
  • Finally installed the latest Bootstrap Blue

I set up Bootstrap Blue as my default theme and it looks quite nice. Good job!
However, after clicking around and trying other modules, I came across something that can kill certain functionality as it relates to forms that use elements that include '#type' => 'tableselect',

It appears that when radios are used, '#multiple' => FALSE, the radios are not rendered.

Here are my settings:

  • jQuery Version: 1.7
  • jQuery compression level: Production (minified)
  • jQuery and jQuery UI CDN: jQuery
  • Bootstrap settings: all default
  • Bootstrap Blue settings: all default

I switched to other themes and I didn't have the above problem, the radios where visible (see screen shots below).

Let me know if there's any additional info you may need from me in order to track this down. I'll be glad to assist. All the best.

p.s. Regarding your #2 point above, "Moving from a master to a major version branch", I followed this exactly: https://drupal.org/node/1127732. I had something like 30+ commits in my master branch. After following the instructions, all of my commit history was moved over to my major branch: 7.x-1.x when I was done. I lost nothing, just FYI.

tr33m4n’s picture

tr33m4n commented

Hello there,

Thank you for your reply :) Regarding the tableselect error, could you test with the stock Bootstrap theme rather than my theme and see whether the issue still occurs? Would set up a tableselect form and test but I don't have the time at the moment to figure out how they work.

That's good to know about not losing commits, I'll remove master branch now

Cheers

tr33m4n’s picture

tr33m4n commented

Hello again,

I managed to get a working tableselect example up and running and have found that it's actually an issue with the Bootstrap project as this error seems to occur with the standard Bootstrap theme that's bundled. I have put together an example form using '#type' => 'tableselect', '#multiple' => FALSE, at the demo site http://test.daniel-doyle.co.uk/examples/tableselect_example for reference and have created a bug report here https://drupal.org/node/2092665

I will update this post when I know more about the issue

Cheers

tr33m4n’s picture

tr33m4n commented

Submitted a patch for committing for Bootstrap 7.x-2.x to fix the problem #2092665: Tableselect table types with '#multiple' => FALSE do not work

tr33m4n’s picture

tr33m4n commented

#2092665: Tableselect table types with '#multiple' => FALSE do not work has now been fixed and a new version of Bootstrap has been released, 7.x-2.2

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Needs review » Reviewed & tested by the community

Looks nice, no problems found.

----
Top Shelf Modules - Crafted, Curated, Contributed.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Reviewed & tested by the community » Fixed

It's been a month without any problems reported, so I'm promoting this myself as per https://drupal.org/node/1125818.

Thanks for your contribution, tr33m4n!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

tr33m4n’s picture

tr33m4n commented

Excellent news, thank you :) Thanks to all the reviewers as well, your help was invaluable!

tr33m4n’s picture

tr33m4n commented
Issue summary: View changes

Updated git branch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.