This experience field save the user experience like 2 Years 7 Month.
It have select list widget to users select the experience.

experience
Project URL:

https://drupal.org/sandbox/balajidharma/2065719

GIT clone:
git clone --branch 7.x-1.x http://git.drupal.org/sandbox/balajidharma/2065719.git experience

Reviews of other projects

  1. https://drupal.org/node/2065035#comment-7764387
  2. https://drupal.org/node/2067173#comment-7764565
  3. https://drupal.org/node/2064915#comment-7769727

Comments

balajidharma’s picture

http://pareview.sh/pareview/httpgitdrupalorgsandboxbalajidharma2065719git

Review of the 7.x-1.x branch:

    This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

    Source: http://ventral.org/pareview - PAReview.sh online service

    balajidharma’s picture

    Issue summary:View changes

    Added Reviews of other projects

    jaffaralia’s picture

    Status:Needs review» Needs work

    Please add detail description from your project home page.
    Add the configuration steps to readme.txt file

    balajidharma’s picture

    Status:Needs work» Needs review

    Added detail description and configuration screenshot in project home page.
    Also added configuration steps in README.txt

    balajidharma’s picture

    Issue summary:View changes

    Added Reviews of other projects

    balajidharma’s picture

    Adding PAReview: review bonus tag for my reviews.

    t14’s picture

    Status:Needs review» Needs work

    Hi

    Not sure if your module offers anything that cannot already be done with existing modules (like the Date module) and standard customisation. You may need to explain why your module is different from the options already out there.

    Thanks
    T

    balajidharma’s picture

    Status:Needs review» Needs work

    Hi T,

    I am working on job portal website. In job portal, i need to store the applicant total years of working experience. The experience field type have year and month select list and save the applicant working experience in float format.

    And also used to capture the max and min year experience in job node creation.

    It's not like existing date module and other modules.

    balajidharma’s picture

    Status:Needs work» Needs review
    Sabareesh’s picture

    Hi,

    I reviewed your work and the code formatting looked good. I tested your module with my content type which had a name, age, experience, company and photo.

    I tried to create a new node with the above mentioned content types and saw the experience field not being saved, also I noticed the below mentioned warning and notice.

    Notice: Undefined index: type in experience_field_formatter_view() (line 43 ../experience.module).
    Warning: Invalid argument supplied for foreach() DatabaseCondition->compile() (line 1854 of includes/database/query.inc)

    balajidharma’s picture

    Status:Needs work» Needs review
    StatusFileSize
    new38.54 KB

    Hi Sabareesh,

    Thanks for reviewing my project. I checked your scenario in my local is working good and also i attached the screenshot of output page.

    Kindly clone the latest code and check your scenario once again.

    Sabareesh’s picture

    Hi balajidharma,

    Sure I will test your code once more in my other local drupal instances and will update you. I will also try to list the entire module's list of my local.

    chester_martin’s picture

    Hi balajidharma,

    I reviewed your module and everything seemed to work correctly. No problem installing and settings up the field on the user account. The values got saved and showed up on the user account page.

    Also the code looks neat and clean.

    I do have two issues though:
    - First, I need to question your choice of how these values are input and stored. The values are quite quickly out-dated if the user doesn't update them all the time. Isn't it better to ask for "Year and month when you first started working in your occupation" or something. Then that date value can be recalculated against the current date.

    - Why is the highest year value set to 30? Some people do have more than 31 years of experience in their field, even if it's not that usual nowadays;-)

    My overall impression is that this can be better done with date field and some custom time output format.

    balajidharma’s picture

    StatusFileSize
    new18.71 KB

    Thanks for reviewing martin sorensson. The project main idea is to capture the total years of experience.

    For your first issue read my comment https://drupal.org/node/2066099#comment-7771507. And also experience field type is possible to use in application forms (capture the total year of experience, relevant field experience ). In most of the job portals applicant total experience will be updated by applicant themselves refer the attached image.

    Second issue:
    Its future plan to set the limit for year (starting and ending year limit).

    chester_martin’s picture

    I understand that the users will probably be updating this info themselves, but none the less, they still need to be fairly active on the portal site to keep it up to date. From a general use perspective it would probably be better to capture the starting date of the experience and have the program calculate how long the experience would be in years/months.

    But of course this is just my opinion. I might be in a minority.;-)

    Good luck!

    gaurav.pahuja’s picture

    My 2 cents:

    Using starting date doesn't fulfill our purpose.It may be the case that there is some non-working period between starting date and current date.

    balajidharma’s picture

    Hi Gaurav Pahuja,

    Thanks for your support.

    klausi’s picture

    Assigned:Unassigned» kscheirer
    Status:Needs review» Reviewed & tested by the community
    Issue tags:-PAReview: review bonus

    manual review:

    1. project page is too short, see https://drupal.org/node/997024
    2. The same functionality can be achieved with the date module, which we use for example for the experience fields in the recruiter distribution. https://drupal.org/project/recruiter . That should be added to the project page with explanation of the differences.

    But otherwise looks RTBC to me. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

    Assigning to kscheirer as he might have time to take a final look at this.

    balajidharma’s picture

    Hi klausi,

    Thanks for reviewing my project. Yes i will update the project page information.

    Yes by using date module we capture the experience. But it is difficult in search to get the specific years experience applicant. Like in search result page i need to display all the applicant with above 2 years of experience. I facing this problem in my job portal.

    kscheirer’s picture

    Assigned:kscheirer» Unassigned
    Status:Reviewed & tested by the community» Needs work

    I can see the use case here - the date module generally works in absolute terms (given 2 dates calculate the difference), not a fixed value.

    I'm not sure about using a float though. You're making year.month into a new number, but it's not clear why? Wouldn't it be easier to have an integer column for each value?

    In experience_external_validate() when validation fails, you're just saving the value 0 - it would be better to actually generate an error and let the user know what's wrong with form_set_error().

    Setting to "needs work" for the value storage, but otherwise I think this is RTBC.

    ----
    Top Shelf Modules - Crafted, Curated, Contributed.

    balajidharma’s picture

    balajidharma’s picture

    Status:Needs work» Needs review

    Hi kscheirer,

    Thanks for spending your time in reviewing my project. I saved year and month in single float format, for easy to handle experience wise ordering and filtering (in search). If saved year and month in two column means it is difficult.

    Now i am checked the validation and set the form_error() for invalid input.

    klausi’s picture

    Status:Needs review» Reviewed & tested by the community

    Note that sorting will fail horribly if you have 1 year and 11 months versus 1 year and 9 months for example. Sorting 1.11 and 1.9 will yield 1.9 as the greater value although it should be the one with 11 months.

    You could store it as 1.09, that would solve the problem.

    Anyway, this is an implementation detail and bug, but not an application blocker.

    kscheirer’s picture

    Status:Reviewed & tested by the community» Fixed

    Yeah, seems reasonable enough.

    Thanks for your contribution, balajidharma!

    I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

    Here are some recommended readings to help with excellent maintainership:

    You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

    Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

    Thanks to the dedicated reviewer(s) as well.

    ----
    Top Shelf Modules - Crafted, Curated, Contributed.

    balajidharma’s picture

    Hi kscheirer,

    I completed full project but i did mistake in Short project name (https://drupal.org/project/2065719). How can i change the Short project name from 2065719 to experience ?

    kscheirer’s picture

    Assigned:Unassigned» klausi

    I'm not sure, klausi might have permissions to do it. If not, you'll probably have to file an issue in the webmaster's queue.

    klausi’s picture

    short project names cannot be changed. You need to create a new sandbox, replace your git remote with that, push all commits and then promote that sandbox.

    balajidharma’s picture

    Hi klausi,

    Thanks for your comment. I created new sandbox project and working on push all commits. After promote this project how can i delete old project https://drupal.org/project/2065719 ?

    klausi’s picture

    Please file a webmaster issue afterwards: http://drupal.org/project/issues/webmasters

    Automatically closed -- issue fixed for 2 weeks with no activity.

    Anonymous’s picture

    Issue summary:View changes

    Added Reviews of other projects 3