Move bulkFormBase out of system module to views module

Have you tried to use https://drupal.org/documentation/git/configure which lets you to provide move only patches?

reroll

It would be great if you could use a git configuration which keeps track of moves, so the patch
size would be reduced quite a lot. (see https://www.drupal.org/documentation/git/configure "Optimize diffs for renamed and copied files").

Rerolled again.

Awesome!

This issue is a normal task so we need to outline how it fits within the allowable Drupal 8 beta criteria. Can someone add Drupal 8 beta phase evaluation template to the issue summary.

Added an issue summary and a beta evaluation. I set the issue back to RTBC, since the patch has not changed. Please let me know if this was an incorrect assumption.

Removed tag 'Needs issue summary update'

I'm not sure there is any value in breaking all contrib modules that extend Drupal\system\Plugin\views\field\BulkForm; this plugin is only used if views is installed. I don't think the benefits outweigh the disruption in this case.

Setting back to "needs review" to give people a chance to disagree.

Its easier to find in views though, you simply don't expect it to be in system module.

I agree with #20. Should we also move tests, schema and hook_views_form_substitutions from action module, and views_field_bulk_form from core.data_types.schema.yml to views here?

@olli afaics action_views_form_substitutions() is not used or tested anywhere. But the answer to your question is yes we should get everything together in the right place.

Removed action_views_form_substitutions() and moved bulk form test and schema to views.

reroll

+++ /dev/null
@@ -1,24 +0,0 @@
-<?php
-
-/**
- * @file
- * Provides views runtime hooks for action.module.
- */
-
-use Drupal\Component\Utility\String;
-
-/**
- * Implements hook_views_form_substitutions().
- */
-function action_views_form_substitutions() {
-  // Views String::checkPlain()s the column label, so we need to match that.
-  $select_all_placeholder = String::checkPlain('<!--action-bulk-form-select-all-->');
-  $select_all = array(
-    '#type' => 'checkbox',
-    '#default_value' => FALSE,
-    '#attributes' => array('class' => array('action-table-select-all')),
-  );
-  return array(
-    $select_all_placeholder => drupal_render($select_all),
-  );
-}
diff --git a/core/modules/action/tests/action_bulk_test/action_bulk_test.info.yml b/core/modules/action/tests/action_bulk_test/action_bulk_test.info.yml

I'm curious, what happened with that bit of code? Can you explain why it can be removed?

Thanks for the review, @dawehner. I couldn't find any other usages of that placeholder or the class. I also don't see why that code was added in #1828410: Provide a bulk_form element for actions. Maybe that part of vbo was not fully included?

Thanks for @bojanz, this is about the select all box, which we afaik want, right? Isn't the all checkbox provided by that?

That's the "select all on all pages", right? And we have only simple select-all checkbox "select all on this page".

@olli I guess so, but well, removing that should be its own scoped issue, IMHO.

This was fixed by #2916451: Move everything related to Bulk Form to Views module. Never found this issue when searching for existing issues before I filed that one :(