Problem/Motivation

comment_load_multiple() is useless wrapper to entity_load_multiple()

Proposed resolution

Replace calls to corresponding:
comment_load_multiple($cids) => entity_load_multiple('comment', $cids)

Remaining tasks

  • Create a patch (5 places to patch)
  • Commit a patch

Related issue #1757586: Remove MODULE_load*() & Co functions in favor of entity_*() functions

CommentFileSizeAuthor
#15 drupal8.comment-module.2054213-15.patch2.12 KBandypost
#12 deprecate-comment-load-multiple-2054213-12.patch3.33 KBstephaneq
#9 deprecate-comment-load-multiple-2054213-9.patch3.3 KBstephaneq
#9 interdiff-7-9.txt563 bytesstephaneq
#7 deprecate-comment-load-multiple-2054213-7.patch3.3 KBstephaneq
#7 interdiff-2-7.txt518 bytesstephaneq
#4 deprecate-comment-load-multiple-2054213-4.patch3.66 KBstephaneq
#4 interdiff.txt887 bytesstephaneq
#2 deprecate-comment-load-multiple-2054213-2.patch2.99 KBstephaneq

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Entity system, +API clean-up

taggin

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented
Status: Active » Needs review
StatusFileSize
new deprecate-comment-load-multiple-2054213-2.patch2.99 KB

Should I remove the function ?

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Yes please

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented
StatusFileSize
new interdiff.txt887 bytes
new deprecate-comment-load-multiple-2054213-4.patch3.66 KB
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Awesome!

$ git grep comment_load_multiple
core/modules/comment/comment.admin.inc:  $comments = comment_load_multiple($cids);
core/modules/comment/comment.module:      $comments = comment_load_multiple($cids);
core/modules/comment/comment.module: *   An array of comments as returned by comment_load_multiple().
core/modules/comment/comment.module:      $comments = comment_load_multiple($cids);
core/modules/comment/comment.module:function comment_load_multiple(array $cids = NULL, $reset = FALSE) {
core/modules/comment/lib/Drupal/comment/Plugin/views/row/Rss.php:    $this->comments = comment_load_multiple($cids);
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Needs work

It's post-API freeze, so that function needs to be marked @deprecated rather than removed, according to http://buytaert.net/drupal-8-api-freeze.

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2-7.txt518 bytes
new deprecate-comment-load-multiple-2054213-7.patch3.3 KB

Ok, here is the change.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Needs work 
+++ b/core/modules/comment/comment.moduleundefined
@@ -1280,6 +1280,8 @@ function comment_user_predelete($account) {
+ * @deprecated use entity_load_multiple('comment', $cids) instead.

should be Use

Sorry for the bum steer at #3

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented
StatusFileSize
new interdiff-7-9.txt563 bytes
new deprecate-comment-load-multiple-2054213-9.patch3.3 KB

Np :)
I get the deprecated statement from taxonomy.module (*_load_multiple functions) so the capital is missing there too.

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented
Status: Needs work » Needs review

Forgot the status

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

drop is moving

stephaneq’s picture

stephaneq
Primary language French
Location Paris 🇫🇷
commented
Status: Needs work » Needs review
StatusFileSize
new deprecate-comment-load-multiple-2054213-12.patch3.33 KB

Rerolling

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Awesome!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Patch no longer applies.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs reroll
StatusFileSize
new drupal8.comment-module.2054213-15.patch2.12 KB

There's only 2 left

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Hm. Not sure I like this general direction of moving away from targeted wrapper functions, but in a quick grep it shows that the ship has already sailed, apparently.

Committed and pushed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.