Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
comment_load_multiple() is useless wrapper to entity_load_multiple()
Proposed resolution
Replace calls to corresponding:
comment_load_multiple($cids) => entity_load_multiple('comment', $cids)
Remaining tasks
- Create a patch (5 places to patch)
- Commit a patch
Related issue #1757586: Remove MODULE_load*() & Co functions in favor of entity_*() functions
Comment | File | Size | Author |
---|---|---|---|
#15 | drupal8.comment-module.2054213-15.patch | 2.12 KB | andypost |
#12 | deprecate-comment-load-multiple-2054213-12.patch | 3.33 KB | StephaneQ |
#9 | deprecate-comment-load-multiple-2054213-9.patch | 3.3 KB | StephaneQ |
#9 | interdiff-7-9.txt | 563 bytes | StephaneQ |
#7 | deprecate-comment-load-multiple-2054213-7.patch | 3.3 KB | StephaneQ |
Comments
Comment #1
andyposttaggin
Comment #2
StephaneQShould I remove the function ?
Comment #3
larowlanYes please
Comment #4
StephaneQComment #5
andypostAwesome!
Comment #6
webchickIt's post-API freeze, so that function needs to be marked @deprecated rather than removed, according to http://buytaert.net/drupal-8-api-freeze.
Comment #7
StephaneQOk, here is the change.
Comment #8
larowlanshould be Use
Sorry for the bum steer at #3
Comment #9
StephaneQNp :)
I get the deprecated statement from taxonomy.module (*_load_multiple functions) so the capital is missing there too.
Comment #10
StephaneQForgot the status
Comment #11
andypostdrop is moving
Comment #12
StephaneQRerolling
Comment #13
andypostAwesome!
Comment #14
alexpottPatch no longer applies.
Comment #15
andypostThere's only 2 left
Comment #16
webchickHm. Not sure I like this general direction of moving away from targeted wrapper functions, but in a quick grep it shows that the ship has already sailed, apparently.
Committed and pushed to 8.x.