Taxonomy vocabulary contextual filters are missing

Adding tag. These aren't available anymore, probably due to the conversion of vocabularies to configuration entities, though
these regressions potentially should be marked as a bug.

Thank you for reporting the issue. This is really valuable information given the fact that not many actually use views already in D8.

Updated issue summary.

Is this going to get some attention?

Is the views argument plugin VocabularyVid used for anything then?

The attached patch simply "enables" the vocabulary contextual filter and adds a test.

+++ b/core/modules/taxonomy/src/Tests/Views/TaxonomyVocabularyArgumentTest.php
@@ -0,0 +1,82 @@
+
+    // Create some term with markup in the label.
...
+    $this->assertEscaped($this->terms[0]->label());
...
+    $this->assertNoEscaped($this->terms[1]->label());

Why the markup? Without the markup you can just assertText, seems more straight forward to me.

The rest looks good to go.

The test is basically copied (and slightly adjusted) from TaxonomyDefaultArgumentTest and TaxonomyTermArgumentDepthTest so I simply used, whats already in core :).

Heh, yeah, doesn't make a lot of sense there either, but good enough reason for me :)

Manually tested this and fixes the issue and adds more test coverage, great!

Works for me too. Thanks!

Patch needs a re-roll for 8.1.x.

Re-rolled patch from https://www.drupal.org/node/2048733#comment-10783780 for 8.1.x

Putting it on the right branch

The reroll isn't quite right.

1. +++ b/core/modules/taxonomy/src/TermViewsData.php
   @@ -71,8 +71,8 @@ public function getViewsData() {
   -    $data['taxonomy_term_field_data']['vid']['field']['help'] = t('The vocabulary name.');
   

   This shouldn't be removed.

2. +++ b/core/modules/taxonomy/src/TermViewsData.php
   @@ -71,8 +71,8 @@ public function getViewsData() {
   +    unset($data['taxonomy_term_field_data']['vid']['field']);
   

   This unset should not be done.

Re-rolled patch https://www.drupal.org/node/2048733#comment-10783780 accordance with https://www.drupal.org/node/2048733#comment-10841162

Thanks for the rerolls @kostyashupenko!

+++ b/core/modules/taxonomy/src/TermViewsData.php
@@ -71,8 +71,9 @@ public function getViewsData() {
+

one last nitpick: extra newline isn't needed.

Re-rolled patch https://www.drupal.org/node/2048733#comment-10841536
in accordance with https://www.drupal.org/node/2048733#comment-10841736

Went through this again, but still felt it could use a bit of a clean up. So here is the cleaned up version of the patch, and the test-only version.

The last patch 2048733-18.patch does not apply, it gives error.

rerolled

The last submitted patch 23: 2048733-23.patch, failed to apply

@swati_qa You tried to apply it to 8.0.x, not 8.1.x. The patch in #23 is for 8.1.x

reroll.

related issue for fields #2658956: Taxonomy vocabulary data not available as views fields

I just applied #32 to my 8.1.9 site and it worked perfectly.

Thanks!

+++ b/core/modules/taxonomy/src/Tests/Views/TaxonomyVocabularyArgumentTest.php
@@ -0,0 +1,81 @@
+  public function testTermWithVocabularyArgument() {
+    $this->drupalGet('test_argument_taxonomy_vocabulary/' . $this->vocabularies[0]->id());
+    // First term should be present.
+    $this->assertText($this->terms[0]->label());
+    // Second term should not be present.
+    $this->assertNoText($this->terms[1]->label());
+  }

This is a really clear test, thank you!

Committed 1e95bd7 and pushed to 8.3.x. Thanks!

Only added to 8.3.x as nothing is broken per-se - this is just enabling something that was available in Drupal 7 views.

diff --git a/core/modules/taxonomy/src/Tests/Views/TaxonomyVocabularyArgumentTest.php b/core/modules/taxonomy/src/Tests/Views/TaxonomyVocabularyArgumentTest.php
index 8e45910..532335f 100644
--- a/core/modules/taxonomy/src/Tests/Views/TaxonomyVocabularyArgumentTest.php
+++ b/core/modules/taxonomy/src/Tests/Views/TaxonomyVocabularyArgumentTest.php
@@ -1,10 +1,5 @@
 <?php
 
-/**
- * @file
- * Contains \Drupal\taxonomy\Tests\Views\TaxonomyVocabularyArgumentTest.
- */
-
 namespace Drupal\taxonomy\Tests\Views;
 
 use Drupal\taxonomy\Entity\Vocabulary;

Removed this on commit since it is no longer the coding standard.

Is this going to make it in to a release? As of 8.8.4 there is no option for a Vocabulary contextual filter.

@jmljuniort ss far as I can tell you need to add a term relationship to get the vocabulery contextual filter in a content view.