Remove references to global user variable in tracker module [#2047935]

Following [#2032447] it is possible to remove (nearly) all calls to the deprecated global user object and replace them with "$user = \Drupal::request()->attributes->get('account');"

This issue in tracker module is the first child of this META issue: #2047951: [META] Remove calls to deprecated global $user and $GLOBALS['user'].

Comment	File	Size	Author
#5	tracker_module_global_user-2047935-5.patch	895 bytes	m1r1k
#5
#1	tracker_module_global_user-2047935-1.patch	653 bytes	stevector
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

stevector

he/him

CreditAttribution: stevector commented 22 July 2013 at 22:59

Status:

Active

» Needs review

File	Size
tracker_module_global_user-2047935-1.patch	653 bytes

Comment #2

Crell CreditAttribution: Crell commented 22 July 2013 at 23:28

1) We may want to change the name of the parameter to the function to avoid confusion.

2) user_access() is now deprecated as well. How many kittens die if we also change that to $account->hasPermission('access content')?

Comment #3

stevector

he/him

CreditAttribution: stevector commented 22 July 2013 at 23:35

@Crell

1) "$account_to_check" ?

2) Five kittens. I didn't know about that deprecation. Is there a change notice? I can't find one. A separate META issue? I'm fine changing it in this issue so long as I can link to a justification.