Closed (fixed)
Project:
Views Slideshow
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Jul 2013 at 20:50 UTC
Updated:
19 Jan 2017 at 06:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
danny englanderI can confirm this, I just ran into the same issue as well. It seems like a new issue as I've been using a similar setup across different sites and never had this issue before now until this new dev version.
I unchecked "Hide controls if there is only one slide" even though I do have more than one slide and that seems to make the error go away. The offending line of code in
views_slideshow.theme.incseems to be:if (empty($vars['settings']['hide_on_single_slide']) || count($vars['rows']) > $vars['view']->style_options['views_slideshow_cycle']['items_per_slide']) { ...... which seems to make sense in the context of the error. It looks like some changes were made back in June that may have given rise to this error.
http://drupalcode.org/project/views_slideshow.git/commitdiff/54b815f7eda...
Comment #2
madmartigan commentedComment #3
zipymonkey commentedThanks for this. There is a similar issue in the _views_slideshow_preprocess_views_slideshow_pager_fields() function at line 241.
Comment #4
r2coder commentedThanks all for the patch. Unfortunately it did not solve the issue in my environment [D7 v34, Visual SlideShow -7.x-3.1]. However, I was able to resolve the problem with the following modification:
Comment #5
jmsv23 commentedThis work for me to remove the errors.
Notice: Undefined index: views_slideshow_cycle in _views_slideshow_preprocess_views_slideshow_pager_fields() (line 241 of views_slideshow/theme/views_slideshow.theme.inc).
Notice: Undefined index: views_slideshow_cycle in theme_views_slideshow_controls_widget_render() (line 291 of views_slideshow/theme/views_slideshow.theme.inc).
Comment #6
socialnicheguru commentedComment #7
interdruper commentedPatch #5 removed the notice for me.
Comment #8
brad.bulger commentedjust a workaround note, might be useful for others who can't apply a patch for reasons: contra comment 1, this went away for me when i turned off "hide controls if there is only one slide", and the error returns if i check it again. this is for Views Slideshow 3.1.
Comment #9
redeight commentedAs far as I can tell, the error only occurs when either control is enabled and the Views Slideshow: Cycle module is not enabled. Seems to me that Views Slideshow is assuming that Views Slideshow: Cycle is always going to be used when this may not be the case. The patch in #5 seems to be a step in the right direction. I feel like we might want to try to find a way to allow other modules to have a hand in this so we aren't so stuck with Views Slideshow: Cycle. Maybe a hook?
Comment #10
madelyncruz commented#5 fixed the error. Thank you.
Comment #12
nickdickinsonwildeNot quite the fix I'd like to do (fully remove cycle centric code from the api module) but fixes the bug in the mean time so applying. Thanks for the patch!