Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
other
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
19 Jul 2013 at 15:26 UTC
Updated:
29 Jul 2014 at 22:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
benjy commentedTagging
Comment #2
benjy commentedComment #3
alexpottCareful with including unrelated change...
Comment #4
benjy commentedGood spot, that was trying to re-install the other day. New patch attached.
Comment #5
sam152 commentedI'm brand new to core development but the above patch looks good to me. Not sure if it should be recreated to respect the 80 character comment limited as per:
// this can quickly lead to Drupal::moduleHandler()->implementsHook() being called several thousand timesBut other than that, looks fine to me.
Comment #6
sam152 commentedComment #7
claudiu.cristeaOnly coding standards comments:
Line too long, wrap to 80 characters. See https://drupal.org/node/1354.
Same here.
Comment #8
benjy commentedNew patch attached.
Comment #9
benjy commentedSettings back to RTBC since it was just a comment change.
Comment #10
catchModuleHandler::invoke() already calls implementsHook() and returns NULL if nothing's there, so we should remove it altogether.
Again this is also checked internally by module_invoke().
Comment #11
benjy commentedThanks, I wasn't aware of that check. New patch attached.
Comment #12
catchComment #13
benjy commentedany reason this still needs work?
Comment #14
catchNope, I forgot to change status with #10, then crossposted with #11.
Comment #15
benjy commentedSetting back.
Comment #16
catchCommited/pushed to 8.x, thanks!