Featurify

Hello,

Did u get the solution for it

This is important, but not a bug. Moving to Feature requests.

If the maintainer agrees that this is needed functionality, then better move it to Tasks, actually.

Hello All,

I have created a patch for it.

Please check it at your end. In my System it is working fine.

Here's a patch. As is stated in the issue title and summary this covers ONLY the Automatic role assignment. Please don't block this patch only because it don't contain all the "Features Integration" functionality. My advice is to treat the other 2 components as separate issues, making them more reviewable. I don't need them right now and I don't have time to work them but I'm OK to provide a review if somebody wants to create them.

Oops!

Thanks Claudiu. I think it makes a good move towards enabling feature integration.

With this as a starting ground I think it will make for updating the user choice and per role page settings.

@mike.davis, then let's RTBC this :)

@claudiu.cristea, I have currently only had a look through the patch and had a quick check with Features but I haven't been able to test it fully yet by creating a feature and applying it to another site.

If someone else has a chance to check that the created feature creates the right settings then I'd be happy to RTFC. Otherwise I will try and have a check of it with the Features module when I get a chance.

OK. This patch covers the whole module. Now everything is exportable with features including the pages.

I don't understand the failure.

Looks like something isn't right with the user logging in, which seems to occur on all the tests, which is causing them to all fail:

Argument 1 passed to DrupalWebTestCase::drupalLogin() must be an instance of stdClass, boolean given, called in /var/lib/drupaltestbot/sites/default/files/checkout/sites/default/modules/autoassignrole/autoassignrole.test on line 42 and defined

The tests are failing when enabling the module.

hm

wrong diff

Let's try with the 'dependencies' option in ::getInfo().

Forgot one test.

Now I got:

run-tests.sh reported no tests were found. See review log for details.

And this I really cannot understand.

OK. So I understand now after @Berdir explained me this failure on IRC. Here's the transcript:

claudiu_cristea: Hi all. Can somebody help me understand this testbot failure? https://qa.drupal.org/pifr/test/1093183
berdir: claudiu_cristea: missing dependencies
berdir: claudiu_cristea: testbot can't handle new dependencies in a patch
berdir: claudiu_cristea: the dependency needs to be added in a separate commit first and then it needs some time to rebuild and learn about that
claudiu_cristea: berdir: thank you so much. so, you mean, that the patch needs to be commited first even it fails with that?
berdir: claudiu_cristea: not that patch. just a one line patch that adds the dependencies line to the info fail
berdir: claudiu_cristea: then wait a day or so until there's a new dev release and testbot rebuilds the dependencies
berdir: claudiu_cristea: info fail = info file 
claudiu_cristea: berdir: I see. Thank you 

So, you'll need to commit first #2531402: Make the module dependent on ctools event is red (that is expected). Postponing this till #2531402: Make the module dependent on ctools goes in. That contains only dependencies[] = ctools line addition and cleanup of unneeded lines.

After applying the patch from #2531402: Make the module dependent on ctools to a 7.x-2.x branch I have updated this to be related to this new dev branch, so hopefully the test should now work for this patch.

Patch. Let's see if the dependency has been propagated.

We have a green patch here :)

Small change.

Is there a chance to have this committed in 7.x-2.x?

I have tried applying this patch, but there were a few patching offset errors - I expect due to the addition of the admin stats from #971614: Introduce states to auto admin settings page.

However, it seems to have added everything from initial glance, so I will commit this shortly for further testing.