This is a preparation step for #2045659: Featurify. We need to add the dependency before committing #2045659: Featurify, otherwise that patch will fail on tesbots.

CommentFileSizeAuthor
#1 make_the_module-2531402-1.patch485 bytesclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon commented
Status: Active » Needs review
FileSize
make_the_module-2531402-1.patch485 bytes

Patch.

Status: Needs review » Needs work

The last submitted patch, 1: make_the_module-2531402-1.patch, failed testing.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon commented
Status: Needs work » Reviewed & tested by the community

This adds only one line

dependencies[] = ctools

I also cleaned some unneeded lines there.

This test will fail forever, so we need to push it in. Marking as RTBC.

mike.davis’s picture

mike.davis CreditAttribution: mike.davis commented

I am happy to commit this to the 7.x branch if needed, but looking at the patch in #2045659: Featurify I'm not sure why there is a need for any dependance on ctools?

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon commented

@mike.davis,

Well, in fact #2045659: Featurify is incomplete. I need to work more. The problem is that, with the existing patch, we are able to export but not to import. I need to replace the custom page loader with the standard provided by CTools. Right now the existing custom loader loads pages only from the DB but it needs to add also pages defined in the code (via hook_autoassignrole_page_default()) and show all together in the table. And this is achieved by using the CTools Export API (ctools_export_crud_load_all() for table with all pages and ctools_export_crud_load() for an individual page). But if this patch doesn't go in we cannot test the other one.

Thats' why I'm proposing a short plan:

  1. Let's create a branch 7.x-2.x and move the 2 issues in 7.x-2.x.
  2. Don't list the 7.x-2.x-dev release on project page.
  3. Add a note on the project page saying that 7.x-2.x-dev is experimental.
  4. When done either (a) make 7.x-2.x the main branch of the project and maintain 7.x-1.x only with security fixes, either (b) merge the work back in 7.x-1.x and delete 7.x-2.x

Let me know.

mike.davis’s picture

mike.davis CreditAttribution: mike.davis commented

Hi Claudiu, this sounds like a good option to get this feature moving forward.

I am conscious that we don't have a 7.x-1.0 official release yet (which I have been working towards getting finished off, as there hasn't been much love on this project for a while), so I think this would be a good step forward.

I'll create the 7.x-2.x branch and move these issues to it and apply this patch to that branch so that you can continue working on #2045659: Featurify.

mike.davis’s picture

mike.davis CreditAttribution: mike.davis commented
Version: 7.x-1.x-dev » 7.x-2.x-dev
Status: Reviewed & tested by the community » Fixed

I've applied this patch to the 7.x-2.x branch now. Hopefully the tests will now work for #2045659: Featurify :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.