Running a pareview reveals lots of small code issues.

CommentFileSizeAuthor
#8 code_cleanup-2041047-8.patch4.56 KBlolandese
#3 code_style_fixes-2041047-3.patch103.74 KBlolandese
#1 code_style_fixes-2041047-1.patch103.44 KBlolandese
pareview_flickr-7x-1x_07-07-2013.txt61.09 KBlolandese

Comments

lolandese’s picture

lolandese commented
Status: Active » Needs review
StatusFileSize
new code_style_fixes-2041047-1.patch103.44 KB

Patch attached that fixes most of them.

lolandese’s picture

lolandese commented
Status: Needs review » Needs work
  • Uninstall hook in flickr.install also removes variables that are related to Flickr block.
  • Uninstall hook in flickr_block.install needs to remove also the recently added variables (flickr_block_7 and on).
  • Remove inline control structure in flickr_filter.module to set a default size.
lolandese’s picture

lolandese commented
Status: Needs work » Needs review
StatusFileSize
new code_style_fixes-2041047-3.patch103.74 KB

New patch fixes #2.

lolandese’s picture

lolandese commented
Status: Needs review » Needs work

EDIT: Removed text. Was intended for another issue. :)

lolandese’s picture

lolandese commented

Changed back status.

lolandese’s picture

lolandese commented
Status: Needs work » Fixed

Tested and committed: http://drupalcode.org/project/flickr.git/commitdiff/bc68c0d

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

lolandese’s picture

lolandese commented
Issue summary: View changes
StatusFileSize
new code_cleanup-2041047-8.patch4.56 KB
lolandese’s picture

lolandese commented

http://drupalcode.org/project/flickr.git/commit/2b42f6a