While the core theme_table does not support multi-row headers, it can fairly easily be adapted to do so. By trivially changing tableheader.js, multi-row headers would be supported. To properly set the width of the sticky header table, only 1 row of headers should have their widths specified.

The two changes would be to add ":first" to the jQuery specifier in Drupal.tableHeader:

  this.originalHeaderCells = this.originalHeader.find('> tr > th'); // existing
  this.originalHeaderCells = this.originalHeader.find('> tr:first > th');  // improved
// ... and
  this.stickyHeaderCells = this.stickyHeader.find('> tr > th'); // existing
  this.stickyHeaderCells = this.stickyHeader.find('> tr:first > th');  // improved

I know that stick tables are being completely rewritten (and hopefully more functional) for D8, so I'm not sure if this change would apply to D8 as well.

The last bit would be to enhance theme_table to support multi-row headers. These are useful (via colspan) to group columns in a meaningful way. But that's a separate issue....

CommentFileSizeAuthor
#12 2039937-12--multi_row_sticky_table_header.patch594 bytesdrunken monkey
#2 2039937-2-multi_row_sticky_table_header--d7--do-not-test.patch665 bytesdrunken monkey
#2 2039937-2-multi_row_sticky_table_header.patch657 bytesdrunken monkey
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ commented
Version: 7.x-dev » 8.x-dev

sticky headers are marginalized in D8 (it's not on by default anymore). And the script has already been optimized in D8 so you can have a look if that'll work there too.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey commented
Issue summary: View changes
Status: Active » Needs review
FileSize
2039937-2-multi_row_sticky_table_header.patch657 bytes
2039937-2-multi_row_sticky_table_header--d7--do-not-test.patch665 bytes

It's hard to test in D8, since there isn't really a module (I know of) yet that adds a second header row, but I've also run into this problem in D7. I also tried to solve it the same way you did – but I found this sometimes leads to wrong results in Chrome.
My new solution, as can be seen in the attached patches, seems to work fine across all browsers, however. Would be great if you could test it to see if it works for you, too – and if we could maybe get this committed in some Drupal version.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Version: 8.0.x-dev » 8.1.x-dev
Status: Needs review » Postponed
Issue tags: +Needs manual testing

Since this is a feature request I'll bump to 8.1.x and postponing on that branch opening. Sorry this didn't get in, it looks quite a simple solution if that's all it is.

droplet’s picture

droplet CreditAttribution: droplet commented

As my understand of HTML5 SPEC, we can't have 2 `thead` in HTML.
(I can be wrong.)

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented

I'm quite sure that's true but you can put in two rows in the thead.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Postponed » Active

Postponed isn't the right status for this, moving back to active. It was really postponed on the release.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
CreditAttribution: drunken monkey as a volunteer commented
FileSize
2039937-12--multi_row_sticky_table_header.patch594 bytes

Thanks for bumping, here's also a re-roll.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.