Convert ActionManager to extend DefaultPluginManager

Thanks for opening the issue!

Apparently it hates caching (wasn't cached in HEAD).

+++ b/core/lib/Drupal/Core/Action/ActionManager.phpundefined
@@ -7,31 +7,37 @@
-  public function __construct(\Traversable $namespaces) {
-    $this->discovery = new AnnotatedClassDiscovery('Action', $namespaces, array(), 'Drupal\Core\Annotation\Action');
...
-    $this->factory = new ContainerFactory($this);

Was there a special reason it didn't had a cache before?

No idea. Let's see what breaks.

Getting a "The plugin (node_delete_action) did not specify an instance class." during the installation. I guess it's trying to do something with the configuration before the caches are cleared?

We might need a generic solution to clear plugin caches when a new module is installed? As this could happen with stuff too?

I know that I had to add a manual cache clear where I'm looking for now plugins in a hook_modules_installed() to create default configuration for them.

I saw the same thing.

I don't know why we don't have that problem for views stuff as well.
I hate to think it might be an alphabetical thing...?

Is it worth having tagged plugin managers?

public function clearAllCachedDefinitons() {
  foreach ($this->pluginManagers as $manager) {
    if ($manager instanceof CachedDiscoveryInterface) {
      $manager->clearCachedDefinitions();
    }
  }
}

I'm not sure...

Opened #2155635: Allow plugin managers to opt in to cache clear during module install for #8/#9.

Picking this up.

Re-roll. No changes. PHPUnit passes.

16: drupal_2039021_16.patch queued for re-testing.

Re-roll, patch applied fine with git apply -3, then updated the cache bin to discovery.

1. +++ b/core/lib/Drupal/Core/Action/ActionManager.php
   @@ -7,31 +7,41 @@
        $this->discovery = new AnnotatedClassDiscovery('Plugin/Action', $namespaces, 'Drupal\Core\Annotation\Action');
   

   We don't need to initialize the discovery here. The parent cares about that and you never know, maybe at some point someone comes up with derivatives for it.

2. +++ b/core/lib/Drupal/Core/Action/ActionManager.php
   @@ -7,31 +7,41 @@
        $this->discovery = new AlterDecorator($this->discovery, 'action_info');
   ...
   +    $this->alterInfo('action_info');
   

   Let's not alter it twice.

Thanks!

Thank you!

Committed/pushed to 8.x, thanks!