Hi there,

first of all, thanks a lot for your module, which is very powerful and easy to use.
My only little problem is: when I tried to upgrade from Alpha1 to Alpha3, the menu appeared normally but... the hover animations (zoom, fading, etc.) went out.

Clearing the cache and reinstalling the module multiple times was totally ineffectual.
Any idea is welcome, just ask me any info you'll think useful for solving this issue.

Regards.

CommentFileSizeAuthor
#5 2038735_fix_disappearing_animations.patch461 bytesm42

Comments

emerham’s picture

emerham commented

Same here, everything is up to date. Any settings that affect the submenu has no effect.

tinkerbelle’s picture

tinkerbelle commented

I can confirm that animation effects are not working on my fresh install of Alpha3 (now using Alpha1 and everything seems fine).

m42’s picture

m42 commented

Updated the version as the problem remains the same in Alpha4 (but it was introduced in Alpha3).

Do you have this problem too ? Even if not, please leave a post there with informations like :
- Module version
- Drupal version
- jQuery and jQuery UI version

Your help is welcome, that issue is becoming a pain in the neck !

arx-e’s picture

arx-e commented
Version: 7.x-1.0-alpha3 » 7.x-1.0-alpha4

Hi, It seems I have this problem in a new installation.

TB Megamenu 7.x-1.0-alpha4
JQuery Update 7.x-2.3+6-dev (set at 1.8, admin 1.5 and UI CDN JQuery)
Drupal 7.22
Omega 3.1 fresh subtheme

I also tried setting the admin JQuery to the same version or version 1.7.
Animation just doesn't happen.
With Bartik theme the same.

Edit: I have not installed Chosen and Font Awesome modules but icons and everything else seem to work.
Edit2: I installed Chosen but nothing changed.

m42’s picture

m42 commented
Status: Active » Needs review
StatusFileSize
new 2038735_fix_disappearing_animations.patch461 bytes

Thank you very much arx-e, your testimony was very valuable !

I think I finally got it: the CSS has changed between Alpha1 and Alpha3, and more specifically the declarations starting with :
.tb-megamenu.animate .mega (~ from line 1455 of default.css) that were changed to :
.tb-megamenu.animate .tb-megamenu-li

But the weak link is: nothing in the template was made to take this change into consideration.

The easiest is to add this line :
$vars['classes_array'][] = 'tb-megamenu-li';
right after line 107 of tb_megamenu.themes.inc.

The corresponding patch is attached, hoping it helps (and that it will be commited for the next release).

m42’s picture

m42 commented
Assigned: Unassigned » m42
arx-e’s picture

arx-e commented

Yeah, I added the line and it works! (With or without Chosen.)
Not very extensive testing but I tried a few different animation settings and they work.

I'm glad my report was of some help - I didn't do much.

So what is the case with Chosen? Do we need it?

m42’s picture

m42 commented

Chosen's role was discussed in this thread: #2024167: drupal 7 tb_megamenu - what is the chosen module dependency for?.
I think it's a really nice module in general, but it's kinda pointless for TB Megamenu.

Anonymous’s picture

Anonymous (not verified) commented

After patch #5 I still have no menu animation, depending on the browser I use:

IE10: the animation is full working: hovering the menu opens the 1st/2nd menu items with a beautifull effect.
Chrome28 and FF22: no animation: a click in the menu opens the 1st submenu without animation, a click in the 2nd menu link geve a animated effect.

Using new installed Drupal7.22 en made test with alpha4 and dev. Als tested with other themes: same effect.

Using Windows 7-64.
In Ubuntu with FF the menu animation works.

Demo site http://demo.themebrain.com/tb_sirate/ give me the same bad result: no menu animation.

My AsuS TF300 Android tablet (test with Chrome and Asus Browser)has also no menu animation as in FF and Chrome in Windows 7.

Strange: on my other notebook Windows7-32 the menu animation works with all the browsers...

m42’s picture

m42 commented

Just to make sure it's the same cause, could you please backup your base.css (located in workflow_fields/css) and replace its content by the following, grabbed from Alpha1: http://pastebin.com/TYUd13J7

Then, run the exact same tests and tell us if everything is OK and/or what has changed.
Thanks a lot !

Anonymous’s picture

Anonymous (not verified) commented

The css from alpha1 did not change anything. I will make a new issue, I think this is not related with the issue discussed here, and I do not want to steal it....

Issue made https://drupal.org/node/2058259

m42’s picture

m42 commented

The issue is still there in Beta2.
Any chance to have the patch in #5 commited ?

m42’s picture

m42 commented
Version: 7.x-1.0-alpha4 » 7.x-1.0-beta2
m42’s picture

m42 commented
Priority: Normal » Major
laryn’s picture

laryn
he/him
commented
Status: Needs review » Reviewed & tested by the community

The line that is added in the patch in #5 solves it for me as well. Can this be committed?

sophiekovalevsky’s picture

sophiekovalevsky commented

Thanks for the patch.

mattsmith3’s picture

mattsmith3 commented

Confirming the patch.

priti197’s picture

priti197 commented

Please add the patch in beta2 version.

Thanks.

skin’s picture

skin
Primary language Italian
Location Italy
commented

I confirm: patch in #5 solves this problem. Can this be committed?

P.S. is this module still developed and mantained?

Thanks

JohnnyW’s picture

JohnnyW commented
Issue summary: View changes

Whoooo, wait wait... #9 is right!

There is no animation as #9 stated on demo... Demo site http://demo.themebrain.com/tb_sirate/ give me the same bad result: no menu animation.

Any suggestions?

Demo won't animate for me on Firefox... is this a demo with out patch?

Thanks!

JohnnyW’s picture

JohnnyW commented

#9 and #20 are correction... no drop down animation with Firefox only.

You have to click once to make animation actually work.

Then click again to open top, first menu in column, else click again to open submenus.

Any suggestions?

paramnida’s picture

paramnida commented

When I apply this patch it wrecks the responsive menu functionality. Does anyone else have this problem? Specifically, once the patch is applied, TB Megamenu no longer recognizes which menu items were indicated in the UI to be "hidden when collapsed." Anyone know how to fix it?

zegara’s picture

zegara commented

This patch works fine with Opera (version 21) and Chrome (version 26), but it not work in Firefox (I used version 31). Does anyone know workaround about this or could it be connected with some other issue?

quondam’s picture

quondam commented
Version: 7.x-1.0-beta2 » 7.x-1.0-rc3
Assigned: m42 » Unassigned
Status: Reviewed & tested by the community » Active

In order to implement this fix the provided patch would need to be re-rolled so that it applies cleanly to the current 7.x-1.0-rc3 branch.

rbrownell’s picture

rbrownell
he/him
Primary language English
Location Gatineau, Québec, Canada
commented
Status: Active » Closed (outdated)

Thanks for the report and for contributing to the TB Mega Menu issue queue.

Drupal 7 reached end of life on January 5, 2025 and is no longer supported going forward.

As part of wrapping up Drupal 7 support for this project, issues that do not include a code-based resolution (including issues where the only patch is out of date and requires a re-roll) are being closed as Outdated as part of this cleanup.

This closure reflects the end-of-life status of Drupal 7 and the absence of an up-to-date fix we can act on, not the validity of the issue itself.

If the issue applies to a currently supported version of Drupal, please open a new issue with updated details.

Thanks again to everyone who contributed during Drupal 7’s lifecycle.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.