Closed (fixed)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
9 Jul 2013 at 22:23 UTC
Updated:
25 Jul 2013 at 20:11 UTC
This is a very small module that adds Delete link as a tab in the node pages.

Sandbox:
https://drupal.org/sandbox/droplet/2038385
Git Repository
http://git.drupal.org:sandbox/droplet/2038385.git
Comments
Comment #1
PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
abhitesh.das commentedHi,
@file doc is missing from the module file. Although, its not a application blocker, but its recommended to follow standards.
However, it would be helpful to open the "delete screen" in an overlay rather than a new page.
Rest all seems fine.
Comment #3
ayesh commentedLooks like a neat small yet handy module!
- add a version-specific branch and remove the master branch.
- in the .info file, add a proper description about the module.
- drupal packaging system will add the version property automatically.
- we don't use "core" as the package name.
Comment #4
julien66 commentedI do agree with what has been said before.
*On delete_tab.info :
Remove package = core
Remove version
Add description
* Fix the versionning branch on your project page.
* Get rid of the coding standard erros on Pareview. (@file doc)
Also unfortunatly althought quite usefull and working, I'm quite afraid (and feel concerned) that this module would be too short to grant its author a 'one time approval' on Drupal.org :
As stated : https://drupal.org/node/1587704
2.3 Ensure your project contains a minimum of handwritten code.
=> Well maybe you could just consider showing another work to get rid of this concern ?
Best
++
Comment #5
droplet commented@abhitesh.das,
@file added. It will open on overlay (base on your account setting)
@Ayesh,
Thanks, All done.
@julien66,
Yeah. I've seen many guys asking for this feature, so create it under 5 minutes.
Sadly, All my modules are tailor-made for single site and I've not been planning to release another module recently.
Check my CORE contribute records if you only want to see my code. I guess it's worth more than 5 functions and 120 lines ?
- https://drupal.org/node/1785310
Understanding how to change default theme function
- https://drupal.org/node/1623574
- https://drupal.org/node/1635394#comment-6498786
Able to write tests.
- https://drupal.org/node/1684976#comment-6255258
Replace things with a more secure function
- https://drupal.org/node/1452188#comment-6085414
Converting to D8 style..etc
- https://drupal.org/node/935208
Although just a few lines of code, you have to understand Field / Widget to get it patched.
- https://drupal.org/node/145353#comment-5993004
Care about performance.
Thanks All.
Comment #6
julien66 commentedOh yes. Definitly.
Sorry for haven't checked.
Comment #7
ayesh commentedLooks great to me too! Good luck!
Comment #8
julien66 commentedJust checked again.
All look nice.
Conclusion => This is a usefull feature that don't already exist. And althought very very tiny, the user can provide obvious demnstration of his Drupal experience in terms of security understanding and API knowledge.
So it's allright here.
I'm changing the issue status to "reviewed and tested by the community".
Best !
++
Comment #9
feolius commentedSorry, missed the window=(
Comment #10
droplet commentedthe window ??
Comment #11
julien66 commentedHi
I guess Feolius was just reviewing another module (https://drupal.org/node/2035383) !
=> I change back the status to reviewed and tested by the community again.
++
Comment #12
mitchell commentedI wanted to see instances of people asking for this, and look what I found:
#4 and #5 were very helpful in deciding to go with full approval. Impressive body of work, droplet! And thanks for asking poignant questions, julien66.
Thanks for your contribution, droplet!
I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.
Here are some recommended readings to help with excellent maintainership:
You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved! Also, consider reviewing other projects that are pending review.
Thanks to the dedicated reviewer(s) as well.
Comment #13.0
(not verified) commentedUpdated issue summary.