[D7] Twitter Tags

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,

I'm trying to enable your module, but for that I need to enable the Twitter module. Unfortunately, it depends on oauth_common module which has no release for D7.

OK thank you.
Maybe you should add a list of modules depending on yours in the description and README file.

Manual review:

Better to add more module dependencies or requirements in info/install file.
Using the drush pm-enable twitter_tags finally got the following message:

No release history available for oauth_common 7.x. [warning]
Module twitter_tags cannot be enabled because it depends on the [error]
following modules which could not be found: oauth_common

Although it is a twitter module related issue, better to add the information in README.txt and project page.

oauth module could be added in the requirements to resolve the oauth_common issue. https://drupal.org/project/oauth

Can this module handle multiple hashtags in a single tweet ?
In twitter_tags_set_tags(), it handles multiple hashtags but when it comes to display them, it seems that the View will show multiple rows for each hashtag found in a particular tweet.

For example, if there is a tweet "#omg #zombies", Views module will show this tweet in a single line. But as your views integration adds a simple join, it will cause Views to display this very same tweet twice, because there are 2 rows in twitter_tags table.
I could not test this yet (I'm not with my own laptop now) but as far as I can remember, this type of views join causes multiple rows.

Also, consider adding all the data in a single database query. db_insert function can handle multiple row inserts in a single database trip.

I will test this awesome work later and will post results.

I did manual testing and it works! One note: the view linked above in comment #1 didn't work for me because it requires a relationship to a Taxonomy Vocabulary that I don't have. I've attached a new exported view that works for me.

Coding standards look good in both Coder and a quick read through. Quick security audit looks good - no HTML is generated anywhere (it's all done by standard views handlers from the views module).

I have a couple minor notes about the API documentation in comments:

• There are three functions (twitter_tags_twitter_status_save(), twitter_tags_set_tags(), and twitter_tags_find_tags()) that take a $status parameter. The doc block should include a @param for it per this document: https://drupal.org/coding-standards/docs#param
• twitter_tags_find_tags() should have a @return per this document: https://drupal.org/coding-standards/docs#return
• In twitter_tags.admin.inc, the form callbacks and submit functions should use the standard descriptions found here: https://drupal.org/coding-standards/docs#forms
• In twitter_tags.install the @file says: "Twitter Taxonomy module hooks" which is wrong - it should probably be something like "Install, update, and uninstall functions for the Twitter Tags module" (copied from https://drupal.org/coding-standards/docs#file)

However, minor nitpicks like those aren't enough to prevent an RTBC.

Great work!

manual review:

• twitter_tags_batch_assign(): Do not use db_select() for simple static queries, use db_query() instead. See http://drupal.org/node/310075

But that is not an application blocker, so ...

Thanks for your contribution, kerasai!

I updated your account so you can promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

Huzzah! Congrats, @kerasai! :-)