Follow up for #1951268: Convert /forum and /forum/% to new router, remove forum_forum_load(), forum_get_topics(), create Forum service

Problem/Motivation

ForumController adds css files individually, ideally this should use a library.

Proposed resolution

Add forum css files to a library and attach them in the controller as such.

Remaining tasks

Write the patch
Review

User interface changes

None

API changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

Whoops, tags cloned via dreditor

RoSk0’s picture

Assigned: larowlan » RoSk0
Status: Active » Needs review
FileSize
1.53 KB

Initial patch.

larowlan’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs architectural review, -Entity system, -Platform Initiative, -WSCCI-conversion
FileSize
25.47 KB

Looks fine to me.
Screenshot from manual testing - the forum icons (which are the main intent of that css file) are still present.
Screenshot 2013-10-01 07.09.37.png

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 69a8334 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.