Updating code is a generic wf_job action and so the logic should sit in that sub module, rather than creating a dependency on the wf_jenkins module, which may not be used.

CommentFileSizeAuthor
#3 wf-update-code-logic-2017409-3.patch8.3 KBskwashd
#1 wf-move-update-code-logic-2017409-1.patch13.42 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented
Category: task » feature
Status: Active » Needs review
StatusFileSize
new wf-move-update-code-logic-2017409-1.patch13.42 KB

The update code logic is now on wf_job.

There a new rules event that is fired by the 'Update code' submit handler, now wf_job have 3 roles related with it, the ones that were in wf_jenkins and a new one called wf_job_update_code_submit.
In wf_jenkins i've created a rules action that receives the job object and handle the code update.

skwashd’s picture

skwashd commented
Status: Needs review » Needs work

This patch doesn't apply cleanly. Please reroll it.

skwashd’s picture

skwashd commented
Status: Needs work » Fixed
StatusFileSize
new wf-update-code-logic-2017409-3.patch8.3 KB

Luiz provided me with the diff directly. It has been applied and committed. Attached is a copy of the patch for the record.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.