Undefined variable in settings form validate [#2015847]

The conditional in the prettify_admin_settings_validate function is checking against a variable that does not exist

if (!empty($form_values['prettify_auto_tags'][PRETTIFY_MARKUP_PRE])) {

Should be:

if (!empty($form_state['values']['prettify_auto_tags'][PRETTIFY_MARKUP_PRE])) {

Comment	File	Size	Author
#1	undefined-var-2015847-1.patch	589 bytes	desmondmorris

Comments

desmondmorris commented 10 June 2013 at 02:25

Status:

Active

» Needs review

Status	File	Size
new	undefined-var-2015847-1.patch	589 bytes

smartinm commented 10 June 2013 at 20:42

Status:

Needs review

» Fixed

Thank you Desmond,

I've committed the patch into 7.x-1.x and 6.x-1.x branch:

24 June 2013 at 20:50

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.