support for ladda library of hiding submit buttons

That would really be cool (see the examples at http://lab.hakim.se/ladda/). Any progress on this?

Should such code go into 7.x-2.x or would it be better to create a new branch such as 7.x-3.x for it?

I have been spending some time looking into implementing the ladda.js library into this module and have discovered one important fact. The ladda library relies on the submit inputs to be buttons. Unfortunately we can not guaranty all the submit inputs are buttons. I can think of a couple ways of getting around this. One would be to perform a $('input.form-submit, button.form-submit').replaceWith('<button/>') in the JS then do a Ladda.bind() on that button, another would be to change the input type to button with in the hook_form_alter, and another would be to customize the library to fit our needs by dissecting out the necessary code to get a similar behavior. In any case, adding a spinner image to an submit input isn't trivial since you can not place in image within an input[type="submit"]'s value attribute.

Being that my strength is in JS I'm leaning toward the last option where we roll our own version of our own ladda.js to fit our needs. Does anyone else have any ideas on how to achieve adding this library to this module?

I decided to go with changing the submit input to a button element using js since this implementation is reliant on js to begin with. I've added the ability to add a data-style and data-spinner-color to the element via the admin ui, the question is, do we want to also have the ability to add more of the library's custom options like data-color, data-size, data-spinner-size, and data-spinner-lines? Thoughts?

I just discovered a glitch in my last patch. When dealing with views ui all visible forms in the DOM submit when using ladda library. I am working on a fix for that. I'm thinking I'll need to implement the library on click.

Here's my new patch, I've included some logic that removes the hide_submit code from views_ui pages which resolves issues I was seeing with the ladda library and will resolve other issues this module is having with the views_ui.

Tested this and it's working, just have a few comments, some which I'm not sure can/need to be resolved.

1.) Typo in comment, // Add a timeout to rerset the buttons (if needed). (this one should be fixed).
2.) Breaks default Drupal styles, which is due to selector specificity in Drupal's css with input.form-submit instead of just .form-submit so I don't think there's anything you can do. You could add a css file that uses .form-submit that just copies Drupal default theme's button styles so that it's pretty easy to override in a theme.
3.) This isn't necessary since Ladda is MIT license, but perhaps it should be loaded through a library? Perhaps it's not worth the extra work and reliance on libraries module as well.

Thanks mike.roberts!

1. I'll fix the typo
2. I'll look at the styling and see if there is a workaround to bring back the drupal styles.
3. greggles and I debated adding Ladda as a library dependency which would create a dependency on libraries and Ladda, or adding the library via the module. We looked at the weight of the library and decided to add it to the module. It's worth noting that the Ladda files do not load on the form unless the user selects the 'Built-in loading indicator' option. My opinion is that we include the library in the module but am happy to add it as a dependency instead.

mike.roberts, the styles I believe you are referring to in #2 are defined by the theme (ie Seven or Barktik) on both the admin and the front facing side of the site, not by core. This creates a bit of a wildcard regarding styling. I'd like to leave things in the css as-is and make no assumptions regarding the theme level's base styling and selectors. Instead I think I'll add the commonly used button class to the newly generated buttons so that it inherits any styles the theme has given that class. How does that sound?

This patch resolves the issues mike.roberts found in the last patch. I chose not to address any issues with css since the issue dealt with the Seven admin theme & the Barktik theme, and none of the other themes that ship with core. We can add the button/input styles from the Seven and Barktik theme if needed but I think we should avoid it since it relies on the assumption that the site is using one of these themes to style their submit buttons/inputs.
In this patch's current state, when the Ladda option is selected the submit inputs on forms are transformed into buttons so that we can add a spinner within them. The two core themes select the inputs via an element selector instead of just a class so the styles for the submit input do not carry over to the button element.
Being that this is determined by the theme I do not feel we should adjust any button css within our styles unless it is needed to achieve our effects.

Normally we don't like 3rd party licensed code on d.o, but it looks like the MIT license is OK, see https://www.drupal.org/node/422996#comment-9654015. However, in that comment they still ask that you make an official exemption request.

You've also introduced 3 new variables that should be removed in hook_uninstall.

Otherwise, patch looks great!

Nice spot @ksheirer. Based on the thread ksheirer points out I recommend we pull Ladda out of the module and make it a library. Then disable the ladda option in the ui until the library is available. We shouldn't need to add the library module as a dependency since the module will still work without ladda or the library module. Does this option sound reasonable?

I'll visit the hook_uninstall suggestion kscheirer recommends and upload a new version of the patch after including the hook and altering things to look for the library. Thanks for the review kscheirer.

Patch seems mis-applied, see #2645506: Duplicate CSS files

This feature addition makes the module much more powerful - thanks a lot! Can we get a new release, so it can actually be used on production sites?

Hm, after updating the Hide submit button module from 7.x-2.2 to 7.x-2.3 I see no changed configuration. In addition, I see no longer any effect on submitting forms :-(

@roball - Hmmm did you run db update and clear your js/css cache?

@rymcveigh, yes, I ran drush updb, but there were No database updates required. Flushing all caches didn't make any difference. Where are the new settings supposed to appear?

@roball, looks like the .module file was not updated with the latest greatest so browsers are looking in the wrong directory for the js file. Looking into it.

It is worth noting that this release includes new permissions where hide_submit will be disabled by default for all user with admin permissions.

Works on simplytest.me. Thanks @greggles!

Thanks for releasing Hide submit button 7.x-2.4, which finally works great with the new Blocking method "Built-in loading indicator.".