On line 213 of includes/context-task-handler.inc, the code decides whether to call drupal_set_title($info['title']) based on whether $info['title'] is set. However, it should be basing that decision on whether $info['title'] is empty. Presumably, the if check if there to prevent accidentally setting the title if the task has no title specified. But '' (empty string) is considered to be "set" (even though it's falsey), so drupal_set_title() gets called unintentionally, which destroys all previous uses of drupal_set_title().

I've attached a patch which fixes this problem.

CommentFileSizeAuthor
ctools-drupal_set_title_fix_for_context_task_handler.patch433 bytescoredumperror

Comments

DamienMcKenna queued ctools-drupal_set_title_fix_for_context_task_handler.patch for re-testing.

coredumperror queued ctools-drupal_set_title_fix_for_context_task_handler.patch for re-testing.

chris matthews’s picture

chris matthews commented
Issue summary: View changes

The 4 year old patch to context-task-handler.inc applied cleanly to the latest ctools 7.x-1.x-dev and if still applicable needs review.

Checking patch includes/context-task-handler.inc...
Hunk #1 succeeded at 214 (offset 4 lines).
Applied patch includes/context-task-handler.inc cleanly.