Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

To Test

  • Step 1: Go to views page (under structure).
  • Step 2: Enable Tracker
  • Step 3: Follow the path
  • Step 4: Make sure the time under "last post" is accurate.
CommentFileSizeAuthor
#11 history-replace_theme_with_drupal_render-2009578-11.patch823 bytesgiammi
#7 history-replace_theme_with_drupal_render-2009578-7.patch830 bytesgiammi
#2 history-replace_theme_with_drupal_render-2009578-2.patch813 bytesinternetdevels

Comments

internetdevels’s picture

internetdevels commented
Assigned: Unassigned » internetdevels

We are working today with this issue during Code Sprint UA.

internetdevels’s picture

internetdevels commented
Assigned: internetdevels » Unassigned
Status: Active » Needs review
Issue tags: +CodeSprintUA
StatusFileSize
new history-replace_theme_with_drupal_render-2009578-2.patch813 bytes

Patch attached.

Status: Needs review » Needs work

The last submitted patch, history-replace_theme_with_drupal_render-2009578-2.patch, failed testing.

thedavidmeister’s picture

thedavidmeister commented
Status: Needs work » Postponed

Unfortunately, because #type is actually a reserved key in renderable arrays we'll need to do this first #2010672: Rename 'type' variable of theme_mark to 'status'.

thedavidmeister’s picture

thedavidmeister commented
Status: Postponed » Needs work

mark has been fixed and is now #mark_type. This is no longer postponed.

giammi’s picture

giammi commented
Assigned: Unassigned » giammi

trying...

giammi’s picture

giammi commented
Status: Needs work » Needs review
StatusFileSize
new history-replace_theme_with_drupal_render-2009578-7.patch830 bytes

Patch attached

thedavidmeister’s picture

thedavidmeister commented
Status: Needs review » Needs work

unfortunately there's a whitespace issue in the patch in #7

thedavidmeister’s picture

thedavidmeister commented
Status: Needs work » Needs review
Issue tags: -Novice, -CodeSprintUA

#7: history-replace_theme_with_drupal_render-2009578-7.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +CodeSprintUA

The last submitted patch, history-replace_theme_with_drupal_render-2009578-7.patch, failed testing.

giammi’s picture

giammi commented
Assigned: giammi » Unassigned
Status: Needs work » Needs review
StatusFileSize
new history-replace_theme_with_drupal_render-2009578-11.patch823 bytes

Removed trailing spaces

Status: Needs review » Needs work
Issue tags: -Novice, -CodeSprintUA

The last submitted patch, history-replace_theme_with_drupal_render-2009578-11.patch, failed testing.

derheap’s picture

derheap commented
Status: Needs work » Needs review

#11: history-replace_theme_with_drupal_render-2009578-11.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, history-replace_theme_with_drupal_render-2009578-11.patch, failed testing.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
Issue tags: +Novice, +CodeSprintUA

#11: history-replace_theme_with_drupal_render-2009578-11.patch queued for re-testing.

adamcowboy’s picture

adamcowboy commented
Issue summary: View changes

Added how to test.

adamcowboy’s picture

adamcowboy commented
Status: Needs review » Reviewed & tested by the community

I tested it and it worked well. I also made a how to test section.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed f6367c5 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Fixed errors from last post.