Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

To Test

  • Step 1: Go to views page (under structure).
  • Step 2: Enable Tracker
  • Step 3: Follow the path
  • Step 4: Make sure the time under "last post" is accurate.
Files: 
CommentFileSizeAuthor
#11 history-replace_theme_with_drupal_render-2009578-11.patch823 bytesgiammi
PASSED: [[SimpleTest]]: [MySQL] 57,718 pass(es).
[ View ]
#7 history-replace_theme_with_drupal_render-2009578-7.patch830 bytesgiammi
FAILED: [[SimpleTest]]: [MySQL] 57,627 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
#2 history-replace_theme_with_drupal_render-2009578-2.patch813 bytesInternetDevels
FAILED: [[SimpleTest]]: [MySQL] 57,136 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Comments

InternetDevels’s picture

Assigned:Unassigned» InternetDevels

We are working today with this issue during Code Sprint UA.

InternetDevels’s picture

Assigned:InternetDevels» Unassigned
Status:Active» Needs review
Issue tags:+CodeSprintUA
StatusFileSize
new813 bytes
FAILED: [[SimpleTest]]: [MySQL] 57,136 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Patch attached.

Status:Needs review» Needs work

The last submitted patch, history-replace_theme_with_drupal_render-2009578-2.patch, failed testing.

thedavidmeister’s picture

Status:Needs work» Postponed

Unfortunately, because #type is actually a reserved key in renderable arrays we'll need to do this first #2010672: Rename 'type' variable of theme_mark to 'status'.

thedavidmeister’s picture

Status:Postponed» Needs work

mark has been fixed and is now #mark_type. This is no longer postponed.

giammi’s picture

Assigned:Unassigned» giammi

trying...

giammi’s picture

Status:Needs work» Needs review
StatusFileSize
new830 bytes
FAILED: [[SimpleTest]]: [MySQL] 57,627 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Patch attached

thedavidmeister’s picture

Status:Needs review» Needs work

unfortunately there's a whitespace issue in the patch in #7

thedavidmeister’s picture

Status:Needs work» Needs review
Issue tags:-Novice, -CodeSprintUA

Status:Needs review» Needs work
Issue tags:+Novice, +CodeSprintUA

The last submitted patch, history-replace_theme_with_drupal_render-2009578-7.patch, failed testing.

giammi’s picture

Assigned:giammi» Unassigned
Status:Needs work» Needs review
StatusFileSize
new823 bytes
PASSED: [[SimpleTest]]: [MySQL] 57,718 pass(es).
[ View ]

Removed trailing spaces

Status:Needs review» Needs work
Issue tags:-Novice, -CodeSprintUA

The last submitted patch, history-replace_theme_with_drupal_render-2009578-11.patch, failed testing.

derheap’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, history-replace_theme_with_drupal_render-2009578-11.patch, failed testing.

hussainweb’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +CodeSprintUA
adamcowboy’s picture

Issue summary:View changes

Added how to test.

adamcowboy’s picture

Status:Needs review» Reviewed & tested by the community

I tested it and it worked well. I also made a how to test section.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed f6367c5 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary:View changes

Fixed errors from last post.