Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Following up on #1812048-11: Build the exposed form using form API functions, Views should use drupal_add_library to attach CSS/JS to form elements.
Comment | File | Size | Author |
---|---|---|---|
#18 | 2005616-18-use_attached_library.patch | 1.99 KB | mikeker |
#13 | 2005616-13-use_attached_library.patch | 1.98 KB | mikeker |
#10 | 2005616-9-use_attached_librarry.patch | 2.82 KB | mikeker |
#5 | 2005616-5-do-not-test.patch | 2.82 KB | mikeker |
#2 | 2005616-2-do-not-test.patch | 2.74 KB | mikeker |
Comments
Comment #1
mikeker CreditAttribution: mikeker commentedThe attached patch makes this change, however it requires the patch in #1812048-9: Build the exposed form using form API functions to be applied first.
Comment #2
mikeker CreditAttribution: mikeker commentedNo need to make the testbot do unnecessary work...
Comment #3
tim.plunkettWe do not want to use drupal_add_library at all.
What we can do is
Can you split this onto multiple lines please?
Comment #4
tim.plunkettComment #5
mikeker CreditAttribution: mikeker commentedGot it. Thanks for the clarification.
Edit: Also breaks css => array() into multiple lines, as requested.
Comment #7
tim.plunkettComment #8
dawehnerThank you very much!
Comment #9
catchWhy the do not test patches? Please let the test bot run through just for sanity.
Comment #10
mikeker CreditAttribution: mikeker commentedI'm pretty sure this patch will not apply until the patch in #1812048: Build the exposed form using form API functions is committed. Is there a better way to handle inter-related issues like this? Should I write this patch to only change the code already in 8.x and reroll #1812048: Build the exposed form using form API functions once this is checked in?
I figured issues with patches that didn't pass the testbot wouldn't get looked at by the powers-that-be so I added the do-not-test suffix. Regardless, let's see what the testbot says...
Comment #12
dawehnerOh damn, you are right.
Btw. this patch misses the new css file.
Comment #13
mikeker CreditAttribution: mikeker commentedOK, slightly different approach... This patch only updates the existing CSS files to use
['#attached']['library']
rather than['#attached']['css']
. So there's no longer a dependency on any other issues.I'll deal with updating the patch in #1812048: Build the exposed form using form API functions if/when this patch is committed.
Apologies for the back and forth -- I should've done it this way from the beginning.
Comment #15
mikeker CreditAttribution: mikeker commented#13: 2005616-13-use_attached_library.patch queued for re-testing.
Comment #16
dawehnerAdding some tags.
Comment #17
alexpottviews.base.css is now views.module.css
Comment #18
mikeker CreditAttribution: mikeker commentedChasing master...
Comment #19
damiankloip CreditAttribution: damiankloip commentedNice, those changes look OK to me!
Comment #20
alexpottCommitted 9c173cf and pushed to 8.x. Thanks!