Support from Acquia helps fund testing for Drupal Acquia logo

Comments

NonProfit’s picture

Assigned: Unassigned » NonProfit
shixish’s picture

Assigned: NonProfit » Unassigned
Status: Active » Needs review
FileSize
1.52 KB

Adjusted the weights in the respective hook_menu blocks.

shixish’s picture

FileSize
10.12 KB

Attached screenshot of how it renders for me.

NonProfit’s picture

Patch created.

Note: To recreate, visit admin/modules and enable the Interface Translation and Language modules. List will appear on admin/config.

marcoscano’s picture

FileSize
46.37 KB

Patch #4 works for me, after clearing caches.

Attached screenshot

screenshot

JulienD’s picture

Status: Needs review » Reviewed & tested by the community

#4 is working and has the same effect that marcoscano's screenshot

YesCT’s picture

Issue tags: +RTBC July 1

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

YesCT’s picture

(tag didn't stick. trying again)

YesCT’s picture

Would alphabetical be better? I'm wondering how the order would change as things are added and deleted from the section if it's decided...

How did you decide on this order? Was it based on what you thought would be used most often in a site that is being built... or something that has been launched for a while and is being used/maintained?

effulgentsia’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

#4 doesn't apply to HEAD any more.

NonProfit’s picture

Assigned: Unassigned » NonProfit
NonProfit’s picture

Assigned: NonProfit » Unassigned
Status: Needs work » Needs review
FileSize
35.69 KB

I believe core now outputs new items in desired order:

  • Regional settings
  • Date and time
  • Languages
  • Translate interface

Note: To recreate, visit admin/modules and enable the Content translation and Locale modules. List will appear on admin/config.

YesCT’s picture

huh. what changed it?

NonProfit’s picture

Assigned: Unassigned » NonProfit
Status: Needs review » Active

Oops, this is my fault! I am learning Acquia Dev Desktop and inadvertently loaded D7 by mistake. Will create a path for D8A2 today.

NonProfit’s picture

Assigned: NonProfit » Unassigned
FileSize
25.39 KB

OK, I'm stuck. After installing D8A2 and enabling all the core Multilingual modules (Content Translation, Interface Translation and Language) I only see Regional settings and Date and time formats in the Regional and language section on /admin/config.

YesCT’s picture

hm.

try making sure you have removed your sites active config. I usually remove the whole sites directory.
and also drop the database and reinstall.

Also, use the git clone command in the version control tab for the drupal project:
https://drupal.org/project/drupal/git-instructions

the current head of 8.x is different than the alpha2.

mducharme’s picture

Status: Active » Needs review
FileSize
1.81 KB

Reroll against HEAD

mducharme’s picture

Issue tags: -Needs reroll

updating tags

NonProfit’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
44.08 KB

Patch #17 works.
Screen Shot 2013-08-16 at 12.40.01 PM.png

kim.pepper’s picture

webchick’s picture

Status: Reviewed & tested by the community » Needs review
Issue tags: -RTBC July 1

This isn't an API change so we don't need to track that.

But I don't see an answer to YesCT's questions in #9.

mducharme’s picture

Is there a standard for grouped lists like this? I would think that alphabetical is a nice default and the "by priority and topic" from OP is subjective. If there's nothing semantically wrong with what's there now, I suggest we mark this as won't fix - unless someone can find an existing pattern.

Bojhan’s picture

The existing pattern is by priority and topic. And that is actually a very sane default from UX standpoint, something that begins W might be used a 100 times more than something that begins with an A, therefor we use priority and topic as a guiding principle see https://drupal.org/node/549094

mducharme’s picture

Thanks for the doc reference. I think the suggested order makes sense.

jsbalsera’s picture

Assigned: Unassigned » jsbalsera
Status: Needs review » Needs work
jsbalsera’s picture

Status: Needs work » Needs review
FileSize
1.86 KB
grisendo’s picture

Works perfect for me :)

Kartagis’s picture

I've tested and can confirm that the patch in #19 works.

Cheers,

Status: Needs review » Needs work

The last submitted patch, Reorder_element_under_configuration-2003812-26.patch, failed testing.

jsbalsera’s picture

Here was the error for the test patch:

The test block appears in the custom category. Other DisplayBlockTest.php 102 Drupal\block\Tests\Views\DisplayBlockTest->testBlockCategory()
The second cloned test block appears in the custom category. Other DisplayBlockTest.php 120 Drupal\block\Tests\Views\DisplayBlockTest->testBlockCategory()

Looks unrelated so I'll send it for re-test.

jsbalsera’s picture

Status: Needs work » Needs review
jsbalsera’s picture

This is how it's seen after the patch

Configuration Regional and Language

penyaskito’s picture

#27 and #28 reported succesful testing, but I'm doubting to RTBC because for sanity maybe we need to use 5 (or 10) multiples for weights.
I will wait for another opinion.

jsbalsera’s picture

Assigned: jsbalsera » Unassigned
FileSize
2.21 KB
1.74 KB

Re-rolled. Also changed the weight from -2 to -5 to use always 5 multiples

jsbalsera’s picture

Issue summary: View changes

Updated issue summary.

penyaskito’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Tested with simplytest.me (http://simplytest.me/project/drupal/8.x?patch[]=https://drupal.org/files..., dreditor still not working for me for getting this links and proper commit messages after d7do upgrade).

The order is as expected in the "after" screenshots at the issue summary.

Xano’s picture

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 34: Reorder_element_under_configuration-2003812-34.patch, failed testing.

Xano’s picture

Status: Needs work » Needs review
FileSize
1.75 KB
balagan’s picture

I have tested the patch in #38, and it is working for me.

balagan’s picture

Status: Needs review » Reviewed & tested by the community
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Looks good. Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.