The menu point regional settings and the menu point date and time formats do belong together because they both touch on the same topics. Furthermore the complexity of the points are quite low, so merging them together would be fine from a usability point of view.
I suggest to build up the new point as follows
Title: Regional, date and time setting
Description text: Set default time zones, default country and configure display format strings for date and time.
Structure of Page
1) Section what is now called 'LOCALE' (change string to 'DEFAULT COUNTRY & LANGUAGE')
2) Section date and time formats
3) Section Default time zones
Comment | File | Size | Author |
---|---|---|---|
#72 | Screenshot 2021-09-28 at 6.50.03 PM.png | 472.85 KB | madhu_h |
#61 | interdiff.txt | 1.16 KB | balagan |
#61 | MergeRegionalAndDateSettings-2003802-61.patch | 23.17 KB | balagan |
#58 | date-and-time-formats-tab-after.jpg | 243.38 KB | balagan |
#58 | date-and-time-formats-page-before.jpg | 191.5 KB | balagan |
Comments
Comment #1
Gábor HojtsySounds like a great idea to me to merge the pages, but maybe use tabs?. This page would be a good home for other locale/regional stuff from contrib I think.
Comment #2
zschmid CreditAttribution: zschmid commentedComment #3
zschmid CreditAttribution: zschmid commentedHere's an initial patch that moves Date & Time formats in a new tab under the regional, date and time settings page as suggested by @Gábor Hojtsy . Clear caches after applying patch.
Side note - I also noticed that after enabling the 'language' module , the new menu items that should appear under configuration > Regional and Language, only appears after you force a cache clear. Did a quick search and couldn't find an issue on this, is this being tracked somewhere? More than happy to open a bug ticket if not.
Comment #4
zschmid CreditAttribution: zschmid commentedComment #5
zschmid CreditAttribution: zschmid commentedComment #7
zschmid CreditAttribution: zschmid commentedThis is failing due to the fact that the path for date-time has change from regional/date-time to regional/settings/date-time . Will push another patch that has updated paths in the tests in a few.
This is my first time updating Drupal automated tests so please let me know if theres another process I should be following.
Many thanks!
Comment #8
zschmid CreditAttribution: zschmid commentedrerolling patch with updated tests
Comment #9
zschmid CreditAttribution: zschmid commentedComment #11
zschmid CreditAttribution: zschmid commentedTweaking patch a little bit. Passing tests locally .
Comment #12
zschmid CreditAttribution: zschmid commentedComment #13
zschmid CreditAttribution: zschmid commentedComment #15
zschmid CreditAttribution: zschmid commented#11: regional_language-2003802-11.patch queued for re-testing.
Comment #17
zschmid CreditAttribution: zschmid commentedOkay - it really works this time. :) Should be all green on the tests. Though - please let me know if we should add any additional tests since the link to 'Date/Time settings has moved off the main settings page'
Comment #18
zschmid CreditAttribution: zschmid commentedComment #20
zschmid CreditAttribution: zschmid commented#17: regional_language-2003802-17.patch queued for re-testing.
Comment #22
zschmid CreditAttribution: zschmid commented#17: regional_language-2003802-17.patch queued for re-testing.
Comment #23
YesCT CreditAttribution: YesCT commentedI think there is something wrong with the testbots. We might have to wait a day and recheck then.
Comment #24
Gábor HojtsyI'm not sure we need to list out all items. Regional and language is already the title of the group of items. We can make this "Regional and locale settings" or something along those lines I think.
Also the description similarly needs some wordsmithing.
First line wrong indent.
Also needs screenshot from before/after to demonstrate what is going on and help support why we'd do this.
Comment #25
zschmid CreditAttribution: zschmid commentedAttaching rerolled patch and screenshots
Comment #26
zschmid CreditAttribution: zschmid commentedmissed the indentation issue in previous patch.
Comment #27
Gábor HojtsyLooking at this, it sounds to me like we'd also want to move the default timezone to the tab and call the tab "Date and time"? That would contain all date and time related settings including the default timezone as well as the formats? Does that sound like a good or bad idea? (I'm just brainstorming.)
Comment #28
zschmid CreditAttribution: zschmid commentedI think this makes a lot of sense to combine all of the date/time settings, including format, on a single tab. I was actually torn between doing this when pushing the initial patch.
Would love to hear feedback from anyone on the usability side of things .
Comment #29
Jose Reyero CreditAttribution: Jose Reyero commentedRelated meta issue, #2052193: [META] Date format localisation is a huge mess, conflicts, does not work, regressed
And related question: Should localization of date and time formats be under User interface translation? (
Comment #30
Jose Reyero CreditAttribution: Jose Reyero commented@Gábor #27
> we'd also want to move the default timezone to the tab and call the tab "Date and time"?
But then the 'First day of week' option too' and that would leave the main 'Settings' tab almost empty, specially without locale module enabled :-(
So I think this patch is ok as it is, and we should commit it ASAP and then we can focus on the localization consistency issues in my previous post.
Only a minor issue with the patch: Default language doesn't exist if locale module not enabled so we better keep the current title or find something better, more generic, like 'Locale settings'.
The rest of the patch looks ready to me.
Comment #31
jair CreditAttribution: jair commentedComment #32
kbentham CreditAttribution: kbentham commentedI have rerolled the patch against the current version of 8.x.
Comment #34
vasi1186 CreditAttribution: vasi1186 commentedI could work on this, is this still something we should do for d8?
Comment #35
Gábor HojtsyI *personally* think this would still be a good idea but I cannot guarantee there is UX team agreement since there was no confirmation of that yet above. I would hate to have people work on this, so maybe ask UX team members to verify. Eg. Bojhan, yoroy, etc.
Comment #36
Gábor HojtsyUsability is prioritized in betas.
Comment #37
_nolocation CreditAttribution: _nolocation commented@Gábor I'm at the drupal dev days and would like to work on this issue. Do we still need to clarify things for it?
Comment #38
Bojhan CreditAttribution: Bojhan commentedCould this get before/after pics?
Comment #39
Bojhan CreditAttribution: Bojhan commentedComment #41
Gábor Hojtsy2.x may still allow these kinds of changes I think :)
Comment #42
balagan CreditAttribution: balagan commentedTrying to work on it during DevDaysMilan
Comment #43
balagan CreditAttribution: balagan commentedI tried to reroll the patch, but so many things have changed, it was easier to rewrite it from scratch. Tests are still not updated, so I expect them to fail.
Comment #44
balagan CreditAttribution: balagan commentedComment #46
balagan CreditAttribution: balagan commentedFixed some tests.
Comment #47
balagan CreditAttribution: balagan commentedComment #49
balagan CreditAttribution: balagan commentedMissed some tests, that are included in this patch.
Comment #50
balagan CreditAttribution: balagan commentedComment #52
balagan CreditAttribution: balagan commentedAnother try for fixing all the tests.
Comment #53
balagan CreditAttribution: balagan commentedComment #55
balagan CreditAttribution: balagan commentedComment #56
balagan CreditAttribution: balagan commentedComment #57
balagan CreditAttribution: balagan commentedComment #58
balagan CreditAttribution: balagan commentedUploaded pictures made before and after applying the patch.
Comment #59
Bojhan CreditAttribution: Bojhan commentedI am not convinced about the "locale" who knows what that means? Cant we go with "date" assuming people think that also implies time? Or perhaps even "timezone" ?
Comment #60
balagan CreditAttribution: balagan commentedOK. I don't like timezone, because the Regional settings tab contains Locale and Timezone settings, and then the title does not refer to the other tab. How about 'Regional settings and date formats'?
Comment #61
balagan CreditAttribution: balagan commentedI have made a patch and an interdiff for the above proposal.
Comment #72
madhu_h CreditAttribution: madhu_h at Acquia for Acquia commentedVerified and tested the Merge request !
https://www.drupal.org/files/issues/MergeRegionalAndDateSettings-2003802...
Testing Steps:
Under Configuration => regional and language, merge Regional settings and date and time formats
Title: Regional, date and time setting Description text: Set default time zones, default country and configure display format strings for date and time.
Structure of Page
1) Section what is now called 'LOCALE' (change string to 'DEFAULT COUNTRY & LANGUAGE') 2) Section date and time formats 3) Section Default time zones
Test Results:
There is an error while applying patch
Refer SS
https://www.drupal.org/files/issues/2021-09-28/Screenshot%202021-09-28%2...
Test Status: FAIL