The menu point regional settings and the menu point date and time formats do belong together because they both touch on the same topics. Furthermore the complexity of the points are quite low, so merging them together would be fine from a usability point of view.

I suggest to build up the new point as follows

Title: Regional, date and time setting
Description text: Set default time zones, default country and configure display format strings for date and time.

Structure of Page

1) Section what is now called 'LOCALE' (change string to 'DEFAULT COUNTRY & LANGUAGE')
2) Section date and time formats
3) Section Default time zones

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Gábor Hojtsy’s picture

Sounds like a great idea to me to merge the pages, but maybe use tabs?. This page would be a good home for other locale/regional stuff from contrib I think.

zschmid’s picture

Assigned: Unassigned » zschmid
zschmid’s picture

Here's an initial patch that moves Date & Time formats in a new tab under the regional, date and time settings page as suggested by @Gábor Hojtsy . Clear caches after applying patch.

Side note - I also noticed that after enabling the 'language' module , the new menu items that should appear under configuration > Regional and Language, only appears after you force a cache clear. Did a quick search and couldn't find an issue on this, is this being tracked somewhere? More than happy to open a bug ticket if not.

zschmid’s picture

Status: Active » Needs review
zschmid’s picture

Assigned: zschmid » Unassigned

Status: Needs review » Needs work

The last submitted patch, regional_language-2003802-3.patch, failed testing.

zschmid’s picture

Assigned: Unassigned » zschmid

This is failing due to the fact that the path for date-time has change from regional/date-time to regional/settings/date-time . Will push another patch that has updated paths in the tests in a few.

This is my first time updating Drupal automated tests so please let me know if theres another process I should be following.

Many thanks!

zschmid’s picture

rerolling patch with updated tests

zschmid’s picture

Assigned: zschmid » Unassigned
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, regional_language-2003802-8.patch, failed testing.

zschmid’s picture

Status: Needs work » Needs review
FileSize
12.92 KB

Tweaking patch a little bit. Passing tests locally .

zschmid’s picture

Status: Needs review » Needs work
zschmid’s picture

Status: Needs work » Needs review
Issue tags: -Novice, -needs initial patch

Status: Needs review » Needs work
Issue tags: -D8MI, -language-base

The last submitted patch, regional_language-2003802-11.patch, failed testing.

zschmid’s picture

Status: Needs work » Needs review

#11: regional_language-2003802-11.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +D8MI, +language-base

The last submitted patch, regional_language-2003802-11.patch, failed testing.

zschmid’s picture

Okay - it really works this time. :) Should be all green on the tests. Though - please let me know if we should add any additional tests since the link to 'Date/Time settings has moved off the main settings page'

zschmid’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: -D8MI, -language-base

The last submitted patch, regional_language-2003802-17.patch, failed testing.

zschmid’s picture

Status: Needs work » Needs review

#17: regional_language-2003802-17.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, regional_language-2003802-17.patch, failed testing.

zschmid’s picture

Status: Needs work » Needs review
Issue tags: +D8MI, +language-base

#17: regional_language-2003802-17.patch queued for re-testing.

YesCT’s picture

I think there is something wrong with the testbots. We might have to wait a day and recheck then.

Gábor Hojtsy’s picture

+++ b/core/modules/system/system.moduleundefined
@@ -859,27 +859,31 @@ function system_menu() {
-    'title' => 'Regional settings',
-    'description' => "Settings for the site's default time zone and country.",
+    'title' => 'Regional, date and time setting',
+    'description' => "Set default time zones, default country and configure display format strings for date and time.",

I'm not sure we need to list out all items. Regional and language is already the title of the group of items. We can make this "Regional and locale settings" or something along those lines I think.

Also the description similarly needs some wordsmithing.

+++ b/core/modules/system/system.moduleundefined
@@ -859,27 +859,31 @@ function system_menu() {
+    $items['admin/config/regional/settings/list'] = array(
+    'title' => 'Settings',
+    'type' => MENU_DEFAULT_LOCAL_TASK,
+  );

First line wrong indent.

Also needs screenshot from before/after to demonstrate what is going on and help support why we'd do this.

zschmid’s picture

Attaching rerolled patch and screenshots

regional-locale-after.png

regional-locale-after2.png

zschmid’s picture

missed the indentation issue in previous patch.

Gábor Hojtsy’s picture

Looking at this, it sounds to me like we'd also want to move the default timezone to the tab and call the tab "Date and time"? That would contain all date and time related settings including the default timezone as well as the formats? Does that sound like a good or bad idea? (I'm just brainstorming.)

zschmid’s picture

Issue tags: -Needs screenshots

I think this makes a lot of sense to combine all of the date/time settings, including format, on a single tab. I was actually torn between doing this when pushing the initial patch.

Would love to hear feedback from anyone on the usability side of things .

Jose Reyero’s picture

Related meta issue, #2052193: [META] Date format localisation is a huge mess, conflicts, does not work, regressed

And related question: Should localization of date and time formats be under User interface translation? (

Jose Reyero’s picture

@Gábor #27
> we'd also want to move the default timezone to the tab and call the tab "Date and time"?

But then the 'First day of week' option too' and that would leave the main 'Settings' tab almost empty, specially without locale module enabled :-(

So I think this patch is ok as it is, and we should commit it ASAP and then we can focus on the localization consistency issues in my previous post.

Only a minor issue with the patch: Default language doesn't exist if locale module not enabled so we better keep the current title or find something better, more generic, like 'Locale settings'.

--- a/core/modules/system/lib/Drupal/system/Form/RegionalForm.php
+++ b/core/modules/system/lib/Drupal/system/Form/RegionalForm.php
@@ -34,7 +34,7 @@ public function buildForm(array $form, array &$form_state) {
 
     $form['locale'] = array(
       '#type' => 'details',
-      '#title' => t('Locale'),
+      '#title' => t('Default Country & Language'),
     );

The rest of the patch looks ready to me.

jair’s picture

Issue tags: +Needs reroll
kbentham’s picture

I have rerolled the patch against the current version of 8.x.

The last submitted patch, drupal8.language-system.2003802-32.patch, failed testing.

vasi1186’s picture

I could work on this, is this still something we should do for d8?

Gábor Hojtsy’s picture

I *personally* think this would still be a good idea but I cannot guarantee there is UX team agreement since there was no confirmation of that yet above. I would hate to have people work on this, so maybe ask UX team members to verify. Eg. Bojhan, yoroy, etc.

Gábor Hojtsy’s picture

Issue summary: View changes
Issue tags: +medium

Usability is prioritized in betas.

_nolocation’s picture

@Gábor I'm at the drupal dev days and would like to work on this issue. Do we still need to clarify things for it?

Bojhan’s picture

Could this get before/after pics?

Bojhan’s picture

Issue tags: -Needs usability review

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Gábor Hojtsy’s picture

Version: 8.1.x-dev » 8.2.x-dev

2.x may still allow these kinds of changes I think :)

balagan’s picture

Assigned: Unassigned » balagan
Issue tags: +DevDaysMilan

Trying to work on it during DevDaysMilan

balagan’s picture

I tried to reroll the patch, but so many things have changed, it was easier to rewrite it from scratch. Tests are still not updated, so I expect them to fail.

balagan’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 43: 2003802-43.patch, failed testing.

balagan’s picture

Fixed some tests.

balagan’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 46: 2003802-46.patch, failed testing.

balagan’s picture

Missed some tests, that are included in this patch.

balagan’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 49: 2003802-49.patch, failed testing.

balagan’s picture

Another try for fixing all the tests.

balagan’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 52: 2003802-52.patch, failed testing.

balagan’s picture

balagan’s picture

Status: Needs work » Needs review
balagan’s picture

Assigned: balagan » Unassigned
balagan’s picture

Uploaded pictures made before and after applying the patch.

Bojhan’s picture

I am not convinced about the "locale" who knows what that means? Cant we go with "date" assuming people think that also implies time? Or perhaps even "timezone" ?

balagan’s picture

OK. I don't like timezone, because the Regional settings tab contains Locale and Timezone settings, and then the title does not refer to the other tab. How about 'Regional settings and date formats'?

balagan’s picture

I have made a patch and an interdiff for the above proposal.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

madhu_h’s picture

Status: Needs review » Needs work
FileSize
472.85 KB

Verified and tested the Merge request !
https://www.drupal.org/files/issues/MergeRegionalAndDateSettings-2003802...

Testing Steps:
Under Configuration => regional and language, merge Regional settings and date and time formats
Title: Regional, date and time setting
Description text: Set default time zones, default country and configure display format strings for date and time.
Structure of Page
1) Section what is now called 'LOCALE' (change string to 'DEFAULT COUNTRY & LANGUAGE')
2) Section date and time formats
3) Section Default time zones

Test Results:
There is an error while applying patch

Refer SS
https://www.drupal.org/files/issues/2021-09-28/Screenshot%202021-09-28%2...

Test Status: FAIL

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.