drupal_container() is deprecated, and all calls in the entity_reference module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154)

Files: 
CommentFileSizeAuthor
#4 replace-drupal_container-2003630-4.patch1.52 KBalexander.ilivanov
PASSED: [[SimpleTest]]: [MySQL] 55,849 pass(es).
[ View ]
#1 2003630-1.patch1.52 KBebeyrent
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

ebeyrent’s picture

Status:Active» Needs review
StatusFileSize
new1.52 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
dawehner’s picture

Looks pretty good. I would assume that there is an issue to convert Drupal::service to Drupal::pluginManager

Status:Needs review» Needs work

The last submitted patch, 2003630-1.patch, failed testing.

alexander.ilivanov’s picture

Assigned:ebeyrent» alexander.ilivanov
Status:Needs work» Needs review
Issue tags:+CodeSprintUA
StatusFileSize
new1.52 KB
PASSED: [[SimpleTest]]: [MySQL] 55,849 pass(es).
[ View ]

drupal_container() replaced
Patch attached.

podarok’s picture

Status:Needs review» Reviewed & tested by the community

if bot happy - rtbc
patch looks good for me

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 24f36dd and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.