drupal_container() is deprecated, and all calls in the editor module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154)

CommentFileSizeAuthor
#9 2003616-replace-drupal_container-editor-module.patch3.71 KBddrozdik
#3 2003616-replace-drupal_container-editor-module.patch3.7 KBddrozdik
#1 2003616-1.patch3.71 KBebeyrent

Comments

ebeyrent’s picture

ebeyrent commented
Status: Active » Needs review
StatusFileSize
new 2003616-1.patch3.71 KB

Status: Needs review » Needs work

The last submitted patch, 2003616-1.patch, failed testing.

ddrozdik’s picture

ddrozdik commented
Assigned: ebeyrent » ddrozdik
Status: Needs work » Needs review
Issue tags: +CodeSprintUA
StatusFileSize
new 2003616-replace-drupal_container-editor-module.patch3.7 KB
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Needs review » Reviewed & tested by the community

#3 clean conversion
RTBC

ebeyrent’s picture

ebeyrent commented 
+++ b/core/modules/editor/editor.module
@@ -130,7 +130,7 @@ function editor_form_filter_admin_overview_alter(&$form, $form_state) {
+  $editors = Drupal::service('plugin.manager.editor')->getDefinitions();

Should be \Drupal::service()?

+++ b/core/modules/editor/editor.module
@@ -324,7 +324,7 @@ function editor_pre_render_format($element) {
+  $manager = Drupal::service('plugin.manager.editor');

Should be \Drupal::service()?

ddrozdik’s picture

ddrozdik commented

I just think we loosely agreed on omitting in procedural code, but It's not wrong in any way though.

ebeyrent’s picture

ebeyrent commented

We should be consistent then, especially in the same piece of code.

ParisLiakos’s picture

ParisLiakos commented

leading backslash is only needed for namespaced code.
any code in .module files is not

ddrozdik’s picture

ddrozdik commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2003616-replace-drupal_container-editor-module.patch3.71 KB

reroll patch

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

ddrozdik’s picture

ddrozdik commented
Status: Fixed » Closed (fixed)