drupal_container() is deprecated, and all calls in the contact module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154)

Files: 
CommentFileSizeAuthor
#3 2003596-replace-drupal_container-contact-module.patch1.48 KBDmitryDrozdik
PASSED: [[SimpleTest]]: [MySQL] 56,048 pass(es).
[ View ]
#1 2003596-1.patch1.49 KBebeyrent
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

ebeyrent’s picture

Status:Active» Needs review
StatusFileSize
new1.49 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Status:Needs review» Needs work

The last submitted patch, 2003596-1.patch, failed testing.

DmitryDrozdik’s picture

Assigned:ebeyrent» DmitryDrozdik
Status:Needs work» Needs review
Issue tags:+CodeSprintUA
StatusFileSize
new1.48 KB
PASSED: [[SimpleTest]]: [MySQL] 56,048 pass(es).
[ View ]

This patch created during Code Sprint UA.

podarok’s picture

Status:Needs review» Reviewed & tested by the community

#3 looks good
if bot green - RTBC

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed b96a264 and pushed to 8.x. Thanks!

DmitryDrozdik’s picture

Status:Fixed» Closed (fixed)