Files: 
CommentFileSizeAuthor
#8 views-rename_op_ends-2003540-8.patch1.73 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 55,819 pass(es). View
#6 views-rename-op_not_ends-2003540-6.patch1.73 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 57,804 pass(es). View
#4 views-rename_op_not_ends-2003540-4.patch1.74 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 56,059 pass(es). View
#2 views.module-rename-op_not_ends_with-2003540-02.patch1.72 KBtoddtomlinson
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

toddtomlinson’s picture

Assigned:Unassigned» toddtomlinson
toddtomlinson’s picture

Assigned:toddtomlinson» Unassigned
Status:Active» Needs review
FileSize
1.72 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Patch attached that renames op_not_ends

Status:Needs review» Needs work

The last submitted patch, views.module-rename-op_not_ends_with-2003540-02.patch, failed testing.

JeroenT’s picture

Status:Needs work» Needs review
FileSize
1.74 KB
PASSED: [[SimpleTest]]: [MySQL] 56,059 pass(es). View

rename op_not_ends() to addNotEndsWith().

heddn’s picture

Title:Rename Views method op_not_ends() to addNotEndsWith()» Rename Views method op_not_ends() to opNotEndsWith()
Status:Needs review» Needs work

In #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_{foo} to add{foo}. So to be consistent this patch should just change the name to opNotEndsWith.

JeroenT’s picture

Status:Needs work» Needs review
FileSize
1.73 KB
PASSED: [[SimpleTest]]: [MySQL] 57,804 pass(es). View

Here is the right patch. Renaming op_not_ends() to OpNotEndsWith().

dawehner’s picture

Status:Needs review» Needs work

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Combine.phpundefined
@@ -116,7 +116,7 @@ function op_ends($expression) {
+  public function opNotEndsWith($expression) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/String.phpundefined
@@ -313,7 +313,7 @@ function op_ends($field) {
+  public function opNotEndsWith($field) {

Should be proctected

JeroenT’s picture

Status:Needs work» Needs review
FileSize
1.73 KB
PASSED: [[SimpleTest]]: [MySQL] 55,819 pass(es). View

Added protected access modifier as mentioned by dawehner.

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

Thank you very much.

alexpott’s picture

Title:Rename Views method op_not_ends() to opNotEndsWith()» Rename Views method op_not_ends() to opNotEnds()
Status:Reviewed & tested by the community» Fixed

Committed 689127e and pushed to 8.x. Thanks!

daven’s picture

Note, the table in the meta issue says to rename to opNotEndsWith but the issue title and patch do not have 'With'

xjm’s picture

Automatically closed -- issue fixed for 2 weeks with no activity.