Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#8 views-rename_op_ends-2003540-8.patch1.73 KBjeroent
#6 views-rename-op_not_ends-2003540-6.patch1.73 KBjeroent
#4 views-rename_op_not_ends-2003540-4.patch1.74 KBjeroent
#2 views.module-rename-op_not_ends_with-2003540-02.patch1.72 KBtoddtomlinson

Comments

toddtomlinson’s picture

toddtomlinson commented
Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

toddtomlinson commented
Assigned: toddtomlinson » Unassigned
Status: Active » Needs review
StatusFileSize
new views.module-rename-op_not_ends_with-2003540-02.patch1.72 KB

Patch attached that renames op_not_ends

Status: Needs review » Needs work

The last submitted patch, views.module-rename-op_not_ends_with-2003540-02.patch, failed testing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new views-rename_op_not_ends-2003540-4.patch1.74 KB

rename op_not_ends() to addNotEndsWith().

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Title: Rename Views method op_not_ends() to addNotEndsWith() » Rename Views method op_not_ends() to opNotEndsWith()
Status: Needs review » Needs work

In #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_{foo} to add{foo}. So to be consistent this patch should just change the name to opNotEndsWith.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new views-rename-op_not_ends-2003540-6.patch1.73 KB

Here is the right patch. Renaming op_not_ends() to OpNotEndsWith().

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Combine.phpundefined
@@ -116,7 +116,7 @@ function op_ends($expression) {
+  public function opNotEndsWith($expression) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/String.phpundefined
@@ -313,7 +313,7 @@ function op_ends($field) {
+  public function opNotEndsWith($field) {

Should be proctected

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new views-rename_op_ends-2003540-8.patch1.73 KB

Added protected access modifier as mentioned by dawehner.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you very much.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Rename Views method op_not_ends() to opNotEndsWith() » Rename Views method op_not_ends() to opNotEnds()
Status: Reviewed & tested by the community » Fixed

Committed 689127e and pushed to 8.x. Thanks!

daven’s picture

daven commented

Note, the table in the meta issue says to rename to opNotEndsWith but the issue title and patch do not have 'With'

xjm’s picture

xjm
she/her
Primary language English
commented

Added followup #1856630: [Change notice] [META] Rename Views methods to core standards per #11.

Automatically closed -- issue fixed for 2 weeks with no activity.