Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#7 rename_views_method-2003528-7.patch1.02 KBmarlatt
#7 interdiff.txt1.04 KBmarlatt
#4 views.module-rename-op_shorter-2003528-04.patch1.02 KBtvlooy
#2 views.module-rename-op_shorter-2003528-02.patch1.02 KBtoddtomlinson

Comments

toddtomlinson’s picture

toddtomlinson commented
Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

toddtomlinson commented
Assigned: toddtomlinson » Unassigned
Status: Active » Needs review
StatusFileSize
new views.module-rename-op_shorter-2003528-02.patch1.02 KB

Patch attached that renames op_shorter to addShorterThan.

Status: Needs review » Needs work

The last submitted patch, views.module-rename-op_shorter-2003528-02.patch, failed testing.

tvlooy’s picture

tvlooy commented
Status: Needs work » Needs review
StatusFileSize
new views.module-rename-op_shorter-2003528-04.patch1.02 KB

Add access modifiers + re-test.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Title: Rename Views method op_shorter() to addShorterThan() » Rename Views method op_shorter() to opShorterThan()

In #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_{foo} to add{foo}. So to be consistent this patch should just change the name to opShorterThan.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

Set to needs work.

marlatt’s picture

marlatt commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.04 KB
new rename_views_method-2003528-7.patch1.02 KB

Changed method names and changed access modifier to protected since this is called inside the class.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Looks fine and this is the only places where this method is used.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Rename Views method op_shorter() to opShorterThan() » Change notice: Rename Views method op_shorter() to opShorterThan()
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to the Views queue for the change notice.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Active » Fixed

Change notice taking place in: #1856630: [Change notice] [META] Rename Views methods to core standards. Marking fixed as this was committed in #9.

Automatically closed -- issue fixed for 2 weeks with no activity.