Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#11 views-rename_op_simple-2003522-11.patch4.17 KBjeroent
#8 drupal_rename_op_simple-2003522-8.patch4.15 KBnathangervais
#5 views-rename_op_simple-2003522-5.patch4.23 KBjeroent
#2 rename_op_simple.patch2.46 KBtrevjs

Comments

trevjs’s picture

trevjs commented
Assigned: Unassigned » trevjs
trevjs’s picture

trevjs commented
Assigned: trevjs » Unassigned
Status: Active » Needs review
StatusFileSize
new rename_op_simple.patch2.46 KB
munizjor’s picture

munizjor commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Date.phpundefined
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/Date.phpundefined
@@ -178,7 +178,7 @@ function op_between($field) {

@@ -178,7 +178,7 @@ function op_between($field) {
+  function addSimpleQuery($field) {

functions needs to be public.

Status: Needs review » Needs work

The last submitted patch, rename_op_simple.patch, failed testing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new views-rename_op_simple-2003522-5.patch4.23 KB

Rename op_simple() to addSimpleQuery().

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Done

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

In #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_whatever to addWhatever. So to be consistent this patch should just change the name to opSimple (we should also drop the Query as it is not a Query - it appears to add a comparison operator)

nathangervais’s picture

nathangervais commented
Status: Needs work » Needs review
StatusFileSize
new drupal_rename_op_simple-2003522-8.patch4.15 KB

Rerolled patch to rename op_simple to opSimple

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Title: Rename Views method op_simple() to addSimpleQuery() » Rename Views method op_simple() to opSimple()

Fixing title

aspilicious’s picture

aspilicious commented
Status: Needs review » Needs work

Talkes with dawehner about this, should be protected. Srry!

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new views-rename_op_simple-2003522-11.patch4.17 KB

Changed access modifier to protected as mentioned by aspilicious.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

No calls are left and code looks fine.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 35a7926 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.