Files: 
CommentFileSizeAuthor
#13 2003470-rename-op_word-protected.patch1.13 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 55,929 pass(es). View
#12 2003470-rename-op_word.patch1.12 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 55,821 pass(es). View
#6 2003470-rename-op_word-protected.patch1.13 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 56,012 pass(es). View
#2 2003470-rename-op_word.patch1.12 KBsillygwailo
PASSED: [[SimpleTest]]: [MySQL] 55,985 pass(es). View

Comments

sillygwailo’s picture

Assigned: Unassigned » sillygwailo

Taking this with baldwinlouie.

sillygwailo’s picture

Status: Active » Needs review
FileSize
1.12 KB
PASSED: [[SimpleTest]]: [MySQL] 55,985 pass(es). View

Patch attached, no manual testing (it appears only in one place).

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2003470-rename-op_word.patch, failed testing.

sillygwailo’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#2: 2003470-rename-op_word.patch queued for re-testing.

oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/String.phpundefined
@@ -268,7 +268,7 @@ function op_contains($field) {
+  function addContainsWord($field) {

Add public access modifier in front of the function to adhere to the new OOP standards.

sillygwailo’s picture

Status: Needs work » Needs review
FileSize
1.13 KB
PASSED: [[SimpleTest]]: [MySQL] 56,012 pass(es). View

Re-rolled with protected.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2003470-rename-op_word-protected.patch, failed testing.

sillygwailo’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2003470-rename-op_word-protected.patch, failed testing.

sillygwailo’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
heddn’s picture

Title: Rename Views method op_word() to addContainsWord() » Rename Views method op_word() to opContainsWord()
Status: Needs review » Needs work

In #2003582: Rename Views method op_equal() to opEqual() it was decided to not rename a function from op_{foo} to add{foo}. So to be consistent this patch should just change the name to opContainsWord.

sillygwailo’s picture

Status: Needs work » Needs review
FileSize
1.12 KB
PASSED: [[SimpleTest]]: [MySQL] 55,821 pass(es). View

Patch attached.

sillygwailo’s picture

FileSize
1.13 KB
PASSED: [[SimpleTest]]: [MySQL] 55,929 pass(es). View

Wrong patch. Right one attached.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2003470-rename-op_word-protected.patch, failed testing.

aspilicious’s picture

Status: Needs work » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed c6698cf and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.