Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#9 views.module-rename_default_display_filters-2003468-9.patch1.2 KBMaxis
#2 views.module-rename-defaul_display_filters-2003468-02.patch1.2 KBtoddtomlinson

Comments

toddtomlinson’s picture

toddtomlinson commented
Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

toddtomlinson commented
StatusFileSize
new views.module-rename-defaul_display_filters-2003468-02.patch1.2 KB

Patch that renames default_display_filters attached.

toddtomlinson’s picture

toddtomlinson commented
Assigned: toddtomlinson » Unassigned
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, views.module-rename-defaul_display_filters-2003468-02.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs work » Needs review
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented

Needs a re-roll:

$ git apply --index views.module-rename-defaul_display_filters-2003468-02.patch
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php:656
error: core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php: patch does not apply

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Needs work
Maxis’s picture

Maxis commented
Assigned: Unassigned » Maxis
Issue tags: +CodeSprintUA

start working

Maxis’s picture

Maxis commented
Category: task » support
Status: Needs work » Needs review
StatusFileSize
new views.module-rename_default_display_filters-2003468-9.patch1.2 KB

Bot?

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Nice!

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC, -CodeSprintUA

The last submitted patch, views.module-rename_default_display_filters-2003468-9.patch, failed testing.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review

#9: views.module-rename_default_display_filters-2003468-9.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, views.module-rename_default_display_filters-2003468-9.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC, +CodeSprintUA

#9: views.module-rename_default_display_filters-2003468-9.patch queued for re-testing.

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community

Thnx!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 31b5fb7 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.