Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#2 2003464-02-rename-operator_options-to-operatorOptions.patch5.3 KBmunizjor
#1 2003464-01-rename-operator_options-to-operatorOptions.patch5.26 KBSpartyDan

Comments

SpartyDan’s picture

SpartyDan commented
Status: Active » Needs review
StatusFileSize
new 2003464-01-rename-operator_options-to-operatorOptions.patch5.26 KB

Patch to rename operator_options() to operatorOptions()

munizjor’s picture

munizjor commented
StatusFileSize
new 2003464-02-rename-operator_options-to-operatorOptions.patch5.3 KB

Updated patch and changed 'functions' to 'public function'.

jmolivas’s picture

jmolivas commented
Status: Needs review » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2003464-02-rename-operator_options-to-operatorOptions.patch, failed testing.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#2: 2003464-02-rename-operator_options-to-operatorOptions.patch queued for re-testing.

elvis2’s picture

elvis2 commented
Status: Needs review » Reviewed & tested by the community

Looks good. Reviewed patch based on: http://drupal.org/node/1856630#comment-7450696

aspilicious’s picture

aspilicious commented

Smells like protected to me. But I'm not 100% sure...

dawehner’s picture

dawehner
Primary language German
commented

It feels like exposed form plugins could potentially use that information so I would rather go with public.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 86b2e89 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.