Files: 
CommentFileSizeAuthor
#5 views-core-operatorValues-2003458-05.patch6.95 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 57,281 pass(es). View
#2 2003458-02-rename-operator_values-to-operatorValues.patch6.93 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 55,696 pass(es). View
#1 2003458-01-rename-operator_values-to-operatorValues.patch6.91 KBSpartyDan
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

SpartyDan’s picture

Status: Active » Needs review
FileSize
6.91 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Patch to rename operator_values() to operatorValues()

SpartyDan’s picture

FileSize
6.93 KB
PASSED: [[SimpleTest]]: [MySQL] 55,696 pass(es). View

changed functions to public functions

aspilicious’s picture

Hmm I think this should be protected and didn't look at the code carefully but we maybe need to move that function to some base class. I have the feeling it does the same thing everywhere.

Again, I didn't look at the actual code just this patch :)

heddn’s picture

Status: Needs review » Needs work
SpartyDan’s picture

Status: Needs work » Needs review
FileSize
6.95 KB
PASSED: [[SimpleTest]]: [MySQL] 57,281 pass(es). View

Changed public to protected and re-rolled

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Hmm I think this should be protected and didn't look at the code carefully but we maybe need to move that function to some base class. I have the feeling it does the same thing everywhere.

But it's not needed on all classes, just saying.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed d72064f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.