Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#5 views-core-operatorValues-2003458-05.patch6.95 KBSpartyDan
#2 2003458-02-rename-operator_values-to-operatorValues.patch6.93 KBSpartyDan
#1 2003458-01-rename-operator_values-to-operatorValues.patch6.91 KBSpartyDan

Comments

SpartyDan’s picture

SpartyDan commented
Status: Active » Needs review
StatusFileSize
new 2003458-01-rename-operator_values-to-operatorValues.patch6.91 KB

Patch to rename operator_values() to operatorValues()

SpartyDan’s picture

SpartyDan commented
StatusFileSize
new 2003458-02-rename-operator_values-to-operatorValues.patch6.93 KB

changed functions to public functions

aspilicious’s picture

aspilicious commented

Hmm I think this should be protected and didn't look at the code carefully but we maybe need to move that function to some base class. I have the feeling it does the same thing everywhere.

Again, I didn't look at the actual code just this patch :)

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Needs work
SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
StatusFileSize
new views-core-operatorValues-2003458-05.patch6.95 KB

Changed public to protected and re-rolled

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Hmm I think this should be protected and didn't look at the code carefully but we maybe need to move that function to some base class. I have the feeling it does the same thing everywhere.

But it's not needed on all classes, just saying.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed d72064f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.