Rename Views method operator_values() to operatorValues() [#2003458]

Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

Comment	File	Size	Author
#5	views-core-operatorValues-2003458-05.patch	6.95 KB	SpartyDan
#5
#2	2003458-02-rename-operator_values-to-operatorValues.patch	6.93 KB	SpartyDan
#2
#1	2003458-01-rename-operator_values-to-operatorValues.patch	6.91 KB	SpartyDan
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

SpartyDan CreditAttribution: SpartyDan commented 24 May 2013 at 19:57

Status:

Active

» Needs review

File	Size
2003458-01-rename-operator_values-to-operatorValues.patch	6.91 KB

Patch to rename operator_values() to operatorValues()

Comment #2

SpartyDan CreditAttribution: SpartyDan commented 24 May 2013 at 22:47

File	Size
2003458-02-rename-operator_values-to-operatorValues.patch	6.93 KB

changed functions to public functions

Comment #3

aspilicious CreditAttribution: aspilicious commented 26 May 2013 at 09:13

Hmm I think this should be protected and didn't look at the code carefully but we maybe need to move that function to some base class. I have the feeling it does the same thing everywhere.

Again, I didn't look at the actual code just this patch :)

Comment #4

heddn

English

Nicaragua

CreditAttribution: heddn commented 29 May 2013 at 13:08

Status:

Needs review

» Needs work

Comment #5

SpartyDan CreditAttribution: SpartyDan commented 30 May 2013 at 03:27

Status:

Needs work

» Needs review

File	Size
views-core-operatorValues-2003458-05.patch	6.95 KB

Changed public to protected and re-rolled

Comment #6

dawehner

German

CreditAttribution: dawehner commented 1 June 2013 at 23:13

Status:

Needs review

» Reviewed & tested by the community

Hmm I think this should be protected and didn't look at the code carefully but we maybe need to move that function to some base class. I have the feeling it does the same thing everywhere.

But it's not needed on all classes, just saying.