Convert CKEditor tests to use $this->container instead of drupal_container()

Attached new patch with some modifications.

#3 clean conversion
RTBC

ebeyrent, No, we should use $this->container in tests instead Drupal::service(), and it's ok, because container already available from parent class and don't need to call again it, just look at parent clases.

Needs a reroll

curl https://drupal.org/files/2003430-replace-drupal_container-ckeditor-module.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  7120  100  7120    0     0   3270      0  0:00:02  0:00:02 --:--:--  4020
error: patch failed: core/modules/ckeditor/lib/Drupal/ckeditor/Plugin/Editor/CKEditor.php:49
error: core/modules/ckeditor/lib/Drupal/ckeditor/Plugin/Editor/CKEditor.php: patch does not apply

Re-rolled

#8: ckeditor-module-replace-drupal_container-2003430-8.patch queued for re-testing.

Bad testbot...Bad! Don't know why this failed so bad the first time. I guess submitting a test in the middle of the night is a not a good idea.

ckeditor seems to work as it should without errors on this mornings build.

+++ b/core/modules/ckeditor/lib/Drupal/ckeditor/Plugin/Editor/CKEditor.phpundefined
@@ -49,7 +49,7 @@ public function getDefaultSettings() {
   public function settingsForm(array $form, array &$form_state, EditorEntity $editor) {
     $module_path = drupal_get_path('module', 'ckeditor');
-    $manager = drupal_container()->get('plugin.manager.ckeditor.plugin');
+    $manager = \Drupal::service('plugin.manager.ckeditor.plugin');
     $ckeditor_settings_toolbar = array(
       '#theme' => 'ckeditor_settings_toolbar',
       '#editor' => $editor,
@@ -114,7 +114,7 @@ public function getJSSettings(EditorEntity $editor) {

@@ -114,7 +114,7 @@ public function getJSSettings(EditorEntity $editor) {
     $language_interface = language(Language::TYPE_INTERFACE);
 
     $settings = array();
-    $manager = drupal_container()->get('plugin.manager.ckeditor.plugin');
+    $manager = \Drupal::service('plugin.manager.ckeditor.plugin');

Now that #1903346: Establish a new DefaultPluginManager to encapsulate best practices has landed lets do the inject properly here...

This means that CKEditorPluginManager will need to be converted to the new DefaultPluginManager class and then the CKEditor plugin will need to be converted to implement ContainerFactoryPluginBase.

This is because replacing drupal_container for \Drupal::service is just replacing a static with a static...

Updating title.

Are you still up for it, DmitryDrozdik or pwieck? I promise fast reviews if you still are! :)

Fix typo.

#13:

• the CKEditor module's plugin manager already got converted to extend DefaultPluginManager in #2039425: Convert CKEditorPluginManager to extend DefaultPluginManager.
• \Drupal\ckeditor\Plugin\Editor\CKEditor is implementing ContainerFactoryPluginInterface as of #1879120: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms.
• there is no need for CKEditor plugins to use ContainerFactoryPluginInterface, since none of them use anything in the container.

Hence the scope of this issue has been reduced to just removing the leftover drupal_container() calls in CKEditor's tests.

Patch attached for just that.

.

Looks pretty straight-forward.

Committed and pushed to 8.x. Thanks!

.