Files: 
CommentFileSizeAuthor
#16 drupal-renameViews-render_items-2003330-16.patch3.47 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 55,962 pass(es).
[ View ]
#12 interdiff.txt1.97 KBheddn
#12 drupal-viewsRenameRenderItems-2003330-12.patch3.46 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 55,073 pass(es).
[ View ]
#9 interdiff.txt3.05 KBheddn
#9 drupal-viewsRenameRenderItems-2003330-9.patch3.42 KBheddn
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]
#3 views_rename_function-2003330-2.patch3.47 KBericthelast
FAILED: [[SimpleTest]]: [MySQL] 56,473 pass(es), 24 fail(s), and 0 exception(s).
[ View ]

Comments

ericthelast’s picture

I'm working on this issue now.

ericthelast’s picture

Assigned:Unassigned» ericthelast
ericthelast’s picture

Status:Active» Needs review
StatusFileSize
new3.47 KB
FAILED: [[SimpleTest]]: [MySQL] 56,473 pass(es), 24 fail(s), and 0 exception(s).
[ View ]

Updated all methods & docblocks references.

Status:Needs review» Needs work

The last submitted patch, views_rename_function-2003330-2.patch, failed testing.

heddn’s picture

Several tests are failing. Needs investigation.

ericthelast’s picture

Yeah, I've looked into it but honestly I'm at a loss. Not sure where to go from here.

heddn’s picture

If we can't figure it out by Thurs night, this would be a good topic for the st louis meetup.

chrisjlee’s picture

Looks like you need to find the class that it's inheriting. I have no clue either it's hard to tell from the patch.

heddn’s picture

Status:Needs work» Needs review
StatusFileSize
new3.42 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]
new3.05 KB

Let's see if this works. I think the changes in #2 were a little too aggressive and also changed 'render_item'.

ericthelast’s picture

Nice catch Lucas! Thanks for looking into it.

Status:Needs review» Needs work

The last submitted patch, drupal-viewsRenameRenderItems-2003330-9.patch, failed testing.

heddn’s picture

Status:Needs work» Needs review
StatusFileSize
new3.46 KB
PASSED: [[SimpleTest]]: [MySQL] 55,073 pass(es).
[ View ]
new1.97 KB

Let's see if this patch will work.

dawehner’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/PrerenderList.phpundefined
@@ -112,7 +112,7 @@ function get_items($values) {
+   * inheriting from this does not implement a 'renderItem' method.

missing s in renderItems

dcam’s picture

Status:Needs review» Needs work

Setting status per #13.

heddn’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/PrerenderList.phpundefined
@@ -112,7 +112,7 @@ function get_items($values) {
+   * inheriting from this does not implement a 'renderItem' method.

Are we sure this should be plural? The actual code calls return method_exists($this, 'render_item'); on line 120.

heddn’s picture

StatusFileSize
new3.47 KB
PASSED: [[SimpleTest]]: [MySQL] 55,962 pass(es).
[ View ]

This patch addresses #13.

heddn’s picture

Status:Needs work» Needs review
dawehner’s picture

Status:Needs review» Reviewed & tested by the community

Nice!

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 579780c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.