Files: 
CommentFileSizeAuthor
#8 2003322-8.patch1.24 KBjibran
PASSED: [[SimpleTest]]: [MySQL] 56,106 pass(es).
[ View ]
#4 views.core-renamed_render_trim_text-2003322-04.patch1.24 KBborisson_
PASSED: [[SimpleTest]]: [MySQL] 55,911 pass(es).
[ View ]
#2 views.core-renamed_render_trim_text-2003322-02.patch1.23 KBtoddtomlinson
PASSED: [[SimpleTest]]: [MySQL] 55,993 pass(es).
[ View ]

Comments

toddtomlinson’s picture

Assigned:Unassigned» toddtomlinson
toddtomlinson’s picture

Assigned:toddtomlinson» Unassigned
Status:Active» Needs review
StatusFileSize
new1.23 KB
PASSED: [[SimpleTest]]: [MySQL] 55,993 pass(es).
[ View ]

Patch to rename render_trim_text attached.

elvis2’s picture

Status:Needs review» Needs work

Thanks for working on this. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

borisson_’s picture

Status:Needs work» Needs review
StatusFileSize
new1.24 KB
PASSED: [[SimpleTest]]: [MySQL] 55,911 pass(es).
[ View ]

Added "public" modifier to function as mentioned in the parent issue: http://drupal.org/node/1856630

borisson_’s picture

Assigned:Unassigned» borisson_

Changed assignee

elvis2’s picture

Status:Needs review» Reviewed & tested by the community

Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

alexpott’s picture

Status:Reviewed & tested by the community» Needs work

Needs a re-roll

curl http://drupal.org/files/views.core-renamed_render_trim_text-2003322-04.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1268  100  1268    0     0   3687      0 --:--:-- --:--:-- --:--:--  7415
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php:1240
error: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php: patch does not apply
jibran’s picture

Status:Needs work» Needs review
StatusFileSize
new1.24 KB
PASSED: [[SimpleTest]]: [MySQL] 56,106 pass(es).
[ View ]

reroll

heddn’s picture

Looks good. All mentions of render_trim_text are changed.

heddn’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed cf185ea and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.