Files: 
CommentFileSizeAuthor
#14 views_rename_setBreadcrumb-2003306-14.patch2.81 KBmarkie
PASSED: [[SimpleTest]]: [MySQL] 56,047 pass(es).
[ View ]
#10 views_rename_setBreadcrumb-2003306-10.patch2.81 KBmarkie
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
#8 views_rename_setBreadcrumb-2003306-8.patch2.81 KBmarkie
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views_rename_setBreadcrumb-2003306-8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#1 rename_setBreadcrumb-2003306-1.patch1.47 KBmarkie
PASSED: [[SimpleTest]]: [MySQL] 57,442 pass(es).
[ View ]

Comments

markie’s picture

Assigned:Unassigned» markie
Status:Active» Needs review
StatusFileSize
new1.47 KB
PASSED: [[SimpleTest]]: [MySQL] 57,442 pass(es).
[ View ]

2 files patched.. Didn't rename the drupal_set_breadcrumb.. figured that'd be bad.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, rename_setBreadcrumb-2003306-1.patch, failed testing.

markie’s picture

Status:Needs work» Needs review

#1: rename_setBreadcrumb-2003306-1.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +VDC

The last submitted patch, rename_setBreadcrumb-2003306-1.patch, failed testing.

heddn’s picture

Failing tests. Please test and re-roll.

markie’s picture

Status:Needs work» Needs review

#1: rename_setBreadcrumb-2003306-1.patch queued for re-testing.

oenie’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -84,7 +84,7 @@ public function init(ViewExecutable $view, DisplayPluginBase $display, array &$o
+  function setBreadcrumb(&$breadcrumb) { }

Add public access modifier in front of the function to adhere to the new OOP standards.

It also seems you have also missed a few occurences of the function:

core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument/IndexTid.php, line 38:
function set_breadcrumb(&$breadcrumb) {

core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument/IndexTidDepth.php, line 72:
function set_breadcrumb(&$breadcrumb) {

markie’s picture

Status:Needs work» Needs review
StatusFileSize
new2.81 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views_rename_setBreadcrumb-2003306-8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Visibility set. I didn't change the taxonomy module files, but now I realize they are extending the views classes. So now they are changed.

Status:Needs review» Needs work

The last submitted patch, views_rename_setBreadcrumb-2003306-8.patch, failed testing.

markie’s picture

Status:Needs work» Needs review
StatusFileSize
new2.81 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

re-rolled on fresh pull.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, views_rename_setBreadcrumb-2003306-10.patch, failed testing.

markie’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work
Issue tags:+Novice, +VDC

The last submitted patch, views_rename_setBreadcrumb-2003306-10.patch, failed testing.

markie’s picture

Status:Needs work» Needs review
StatusFileSize
new2.81 KB
PASSED: [[SimpleTest]]: [MySQL] 56,047 pass(es).
[ View ]

re-rolled

oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 7b3a9a9 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.