Rename Views method set_breadcrumb() to setBreadcrumb()

2 files patched.. Didn't rename the drupal_set_breadcrumb.. figured that'd be bad.

#1: rename_setBreadcrumb-2003306-1.patch queued for re-testing.

Failing tests. Please test and re-roll.

#1: rename_setBreadcrumb-2003306-1.patch queued for re-testing.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -84,7 +84,7 @@ public function init(ViewExecutable $view, DisplayPluginBase $display, array &$o
+  function setBreadcrumb(&$breadcrumb) { }

Add public access modifier in front of the function to adhere to the new OOP standards.

It also seems you have also missed a few occurences of the function:

core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument/IndexTid.php, line 38:
function set_breadcrumb(&$breadcrumb) {

core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument/IndexTidDepth.php, line 72:
function set_breadcrumb(&$breadcrumb) {

Visibility set. I didn't change the taxonomy module files, but now I realize they are extending the views classes. So now they are changed.

re-rolled on fresh pull.

#10: views_rename_setBreadcrumb-2003306-10.patch queued for re-testing.

re-rolled

Looks good to me now !

Committed 7b3a9a9 and pushed to 8.x. Thanks!