Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#14 | views_rename_setBreadcrumb-2003306-14.patch | 2.81 KB | markie |
#10 | views_rename_setBreadcrumb-2003306-10.patch | 2.81 KB | markie |
#8 | views_rename_setBreadcrumb-2003306-8.patch | 2.81 KB | markie |
#1 | rename_setBreadcrumb-2003306-1.patch | 1.47 KB | markie |
Comments
Comment #1
markie CreditAttribution: markie commented2 files patched.. Didn't rename the drupal_set_breadcrumb.. figured that'd be bad.
Comment #3
markie CreditAttribution: markie commented#1: rename_setBreadcrumb-2003306-1.patch queued for re-testing.
Comment #5
heddnFailing tests. Please test and re-roll.
Comment #6
markie CreditAttribution: markie commented#1: rename_setBreadcrumb-2003306-1.patch queued for re-testing.
Comment #7
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the function to adhere to the new OOP standards.
It also seems you have also missed a few occurences of the function:
core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument/IndexTid.php, line 38:
function set_breadcrumb(&$breadcrumb) {
core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/argument/IndexTidDepth.php, line 72:
function set_breadcrumb(&$breadcrumb) {
Comment #8
markie CreditAttribution: markie commentedVisibility set. I didn't change the taxonomy module files, but now I realize they are extending the views classes. So now they are changed.
Comment #10
markie CreditAttribution: markie commentedre-rolled on fresh pull.
Comment #12
markie CreditAttribution: markie commented#10: views_rename_setBreadcrumb-2003306-10.patch queued for re-testing.
Comment #14
markie CreditAttribution: markie commentedre-rolled
Comment #15
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #16
alexpottCommitted 7b3a9a9 and pushed to 8.x. Thanks!