Rename Views method set_count_field() to setCountField()

#2: drupal-set-count-field-2003304.patch queued for re-testing.

retest was successful - code is not related, and it was a very, very busy day for testBot

Looks good to me !

Needs a re-roll

 curl http://drupal.org/files/drupal-set-count-field-2003304.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3633  100  3633    0     0  10471      0 --:--:-- --:--:-- --:--:-- 21000
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/argument/String.php:157
error: core/modules/views/lib/Drupal/views/Plugin/views/argument/String.php: patch does not apply

re-roll

Cool

Needs a re-roll

curl https://drupal.org/files/views-core-setFieldCount-2003304-10.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3637  100  3637    0     0   3852      0 --:--:-- --:--:-- --:--:--  4717
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/argument/String.php:157
error: core/modules/views/lib/Drupal/views/Plugin/views/argument/String.php: patch does not apply

re-roll

- * - set_count_field: Reset the count field so we get the right paging.
+ * - setCountField: Reset the count field so we get the right paging.

I'm not sure this change is correct. Think this is an array property in stead of function name. Someone needs to verify this. Setting to needs work because I'm prety sure there is indeed a problem.

@aspilicious, I would tend to agree with you in #14, however the precedent seems that other fields have already changed similarly in #2001320: Rename Views method add_groupby() to addGroupBy() & #2002144: Rename Views method add_field() to addField().

Since we need a reroll, one is attached.

Committed 00a4259 and pushed to 8.x. Thanks!