Files: 
CommentFileSizeAuthor
#16 drupal-viewsRename-set_count_field-2003304-16.patch4.24 KBheddn
PASSED: [[SimpleTest]]: [MySQL] 58,123 pass(es).
[ View ]
#13 2003304-13.patch3.57 KBjibran
PASSED: [[SimpleTest]]: [MySQL] 56,793 pass(es).
[ View ]
#10 views-core-setFieldCount-2003304-10.patch3.55 KBSpartyDan
PASSED: [[SimpleTest]]: [MySQL] 55,933 pass(es).
[ View ]
#8 2003304-8.patch3.55 KBjibran
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2003304-8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#2 drupal-set-count-field-2003304.patch3.55 KBgdf
PASSED: [[SimpleTest]]: [MySQL] 56,636 pass(es).
[ View ]

Comments

gdf’s picture

Assigned:Unassigned» gdf
gdf’s picture

Status:Active» Needs review
StatusFileSize
new3.55 KB
PASSED: [[SimpleTest]]: [MySQL] 56,636 pass(es).
[ View ]

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, drupal-set-count-field-2003304.patch, failed testing.

gdf’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#2: drupal-set-count-field-2003304.patch queued for re-testing.

gdf’s picture

Assigned:gdf» Unassigned

retest was successful - code is not related, and it was a very, very busy day for testBot

oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me !

alexpott’s picture

Status:Reviewed & tested by the community» Needs work

Needs a re-roll

curl http://drupal.org/files/drupal-set-count-field-2003304.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3633  100  3633    0     0  10471      0 --:--:-- --:--:-- --:--:-- 21000
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/argument/String.php:157
error: core/modules/views/lib/Drupal/views/Plugin/views/argument/String.php: patch does not apply
jibran’s picture

Status:Needs work» Needs review
StatusFileSize
new3.55 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2003304-8.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

re-roll

Status:Needs review» Needs work

The last submitted patch, 2003304-8.patch, failed testing.

SpartyDan’s picture

Status:Needs work» Needs review
StatusFileSize
new3.55 KB
PASSED: [[SimpleTest]]: [MySQL] 55,933 pass(es).
[ View ]

re-rolled

dawehner’s picture

Status:Needs review» Reviewed & tested by the community

Cool

alexpott’s picture

Status:Reviewed & tested by the community» Needs work

Needs a re-roll

curl https://drupal.org/files/views-core-setFieldCount-2003304-10.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3637  100  3637    0     0   3852      0 --:--:-- --:--:-- --:--:--  4717
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/argument/String.php:157
error: core/modules/views/lib/Drupal/views/Plugin/views/argument/String.php: patch does not apply
jibran’s picture

Status:Needs work» Needs review
StatusFileSize
new3.57 KB
PASSED: [[SimpleTest]]: [MySQL] 56,793 pass(es).
[ View ]

re-roll

aspilicious’s picture

- * - set_count_field: Reset the count field so we get the right paging.
+ * - setCountField: Reset the count field so we get the right paging.

I'm not sure this change is correct. Think this is an array property in stead of function name. Someone needs to verify this. Setting to needs work because I'm prety sure there is indeed a problem.

aspilicious’s picture

Status:Needs review» Needs work
heddn’s picture

Status:Needs work» Needs review
StatusFileSize
new4.24 KB
PASSED: [[SimpleTest]]: [MySQL] 58,123 pass(es).
[ View ]

@aspilicious, I would tend to agree with you in #14, however the precedent seems that other fields have already changed similarly in #2001320: Rename Views method add_groupby() to addGroupBy() & #2002144: Rename Views method add_field() to addField().

Since we need a reroll, one is attached.

aspilicious’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 00a4259 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.