Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#16 | drupal-viewsRename-set_count_field-2003304-16.patch | 4.24 KB | heddn |
#13 | 2003304-13.patch | 3.57 KB | jibran |
#10 | views-core-setFieldCount-2003304-10.patch | 3.55 KB | SpartyDan |
#8 | 2003304-8.patch | 3.55 KB | jibran |
#2 | drupal-set-count-field-2003304.patch | 3.55 KB | gdf |
Comments
Comment #1
gdf CreditAttribution: gdf commentedComment #2
gdf CreditAttribution: gdf commentedComment #4
gdf CreditAttribution: gdf commented#2: drupal-set-count-field-2003304.patch queued for re-testing.
Comment #5
gdf CreditAttribution: gdf commentedretest was successful - code is not related, and it was a very, very busy day for testBot
Comment #6
oenie CreditAttribution: oenie commentedLooks good to me !
Comment #7
alexpottNeeds a re-roll
Comment #8
jibranre-roll
Comment #10
SpartyDan CreditAttribution: SpartyDan commentedre-rolled
Comment #11
dawehnerCool
Comment #12
alexpottNeeds a re-roll
Comment #13
jibranre-roll
Comment #14
aspilicious CreditAttribution: aspilicious commented- * - set_count_field: Reset the count field so we get the right paging.
+ * - setCountField: Reset the count field so we get the right paging.
I'm not sure this change is correct. Think this is an array property in stead of function name. Someone needs to verify this. Setting to needs work because I'm prety sure there is indeed a problem.
Comment #15
aspilicious CreditAttribution: aspilicious commentedComment #16
heddn@aspilicious, I would tend to agree with you in #14, however the precedent seems that other fields have already changed similarly in #2001320: Rename Views method add_groupby() to addGroupBy() & #2002144: Rename Views method add_field() to addField().
Since we need a reroll, one is attached.
Comment #17
aspilicious CreditAttribution: aspilicious commentedComment #18
alexpottCommitted 00a4259 and pushed to 8.x. Thanks!